Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can still lose the pickaxe in the mine with a reclaimed disarming trap #1884

Open
chorby-short opened this issue Oct 26, 2024 · 1 comment

Comments

@chorby-short
Copy link

Not sure if you care, but considering you took provisions to prevent it being transmuted or dropped, thought you might want to know.

@00-Evan 00-Evan added the Quirk label Oct 26, 2024
@00-Evan 00-Evan added this to the v3.0.0 milestone Oct 26, 2024
@00-Evan 00-Evan self-assigned this Oct 26, 2024
@00-Evan
Copy link
Owner

00-Evan commented Oct 30, 2024

This turned out to be very specific!

Disarming traps already have a little internal logic that prevents them from teleporting the hero's weapon too close or too far, and that check includes only treating pathable terrain from the current hero position as valid. However, if there is no valid walkable position (e.g. if the hero is in a tiny enclosed room) then the trap will simply give up and use a purely random position. Fix here is to just have the trap's effect fail entirely if there's no valid pathable position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@00-Evan @chorby-short and others