Pass in genericParamProvider

[CreateAndInject]

No description provided.

[wtfsck]

Could you explain what this PR improves?

[CreateAndInject]

Could you explain what this PR improves?

Some code depends on IMethod.FullName:
if (method.FullName == "System.Void System.Collections.Generic.ICollection`1::Add(T)")
This check will be failed when there's no onwer, since FullName will be System.Void System.Collections.Generic.ICollection`1::Add(!0) without owner.

[wwh1004]

If uses dnlib to import a TypeSig from one ModuleDefMD to another ModuleDefMD, we shouldn't assume the imported TypeSig is in the same gp context. Even in the same ModuleDefMD, just importing a TypeSig from one type to another, the gp context is indeterminate.
This pr will result in not being able to get a TypeSig with an empty gp context (gp context is read-only, GenericSig cannot be modified after it has been created).

[CreateAndInject]

If uses dnlib to import a TypeSig from one ModuleDefMD to another ModuleDefMD, we shouldn't assume the imported TypeSig is in the same gp context. Even in the same ModuleDefMD, just importing a TypeSig from one type to another, the gp context is indeterminate.

I think GenericParamContext is designed as:

new Importer(module, new GenericParamContext(member1context)).Import(member1);
new Importer(module, new GenericParamContext(member2context)).Import(member2);
...

rather than use:

module.Import(member1);
module.Import(member2);
...

In this PR, preparing different Importers/GenericParamContexts are unnecessary in some cases, just module.Import(...)

This pr will result in not being able to get a TypeSig with an empty gp context (gp context is read-only, GenericSig cannot be modified after it has been created).

I don't understand, can you explain more?

[wwh1004]

gp context is a parameter designed for display. You can leave it empty.

[CreateAndInject]

gp context is a parameter designed for display. You can leave it empty.

Yes, that's why I check if (gpContext.Type is null &&, I only resolve type/method when user doesn't support gpContext

[wwh1004]

Almost all existing code does not pass gp context, even de4dot, ConfuserEx. When the gp context is empty, it cannot be assumed that the gp context of TypeSig is consistent with the original one.
Suppose someone uses dnlib to import the TypeSig of module A into module B, and then disposes the ModuleDefMD of A. Then there will be a disposed object in the imported TypeSig in module B. So everyone must use the Importer's constructor with gp context overload. This will change everyone's usage habits.

[CreateAndInject]

When the gp context is empty, it cannot be assumed that the gp context of TypeSig is consistent with the original one.

If the gp context is empty, everything is null, what do you mean consistent with? Whether we use an empty gp context or not, there's no difference.

Suppose someone uses dnlib to import the TypeSig of module A into module B, and then disposes the ModuleDefMD of A. Then there will be a disposed object in the imported TypeSig in module B.

Yes, otherwise we can't get the correct FullName when our code calls generic members defined in other assembly, eg: T System.Activator::CreateInstance<T>()
This also happen in .NET Core, can you fix #453 so that dnlib can resolve .NET Core assembly.