Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check fails after base branch is merge into PR #34

Open
krishantaylor opened this issue Sep 12, 2024 · 0 comments
Open

check fails after base branch is merge into PR #34

krishantaylor opened this issue Sep 12, 2024 · 0 comments

Comments

@krishantaylor
Copy link

This check returns a false positive in the following scenario:

  1. Create a new PR
  2. Add a commit with a fixup (action correctly fails)
  3. Update the PR with the base branch (action incorrectly succeeds)

I think it has something to do with the shallow-exclude in the checkout, where it might be ignoring any prior commits to the PR branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krishantaylor