Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Loc models disappearing/uncaching? #24

Open
ultraviolet-jordan opened this issue Nov 8, 2024 · 2 comments
Open

Problem with Loc models disappearing/uncaching? #24

ultraviolet-jordan opened this issue Nov 8, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ultraviolet-jordan
Copy link
Collaborator

ultraviolet-jordan commented Nov 8, 2024

There have been a couple reports over the past year of a specific set of gates disappearing. These here between Falador & Taverly.

image


There was a previous report about 6 months ago where the gates turned into a black square box. I don't have the photo but this is a recreation of what it looked like:

image


I don't believe this is a server issue, I believe there is a problem with model caching or something going on with the Locs. This is because the collision is still working properly, meaning the client is aware that the gates are there. (we use the client pathfinding which means it must be aware of the maps collision). Not sure as this issue is not easily reproducible, and not sure on the control flow to make it happen. Both reports, the players were doing the Witch quest nearby.

  • Relogging on the client fixes the models.
  • I have 0 idea if this is a bug in the vanilla java client or not either. I am making a bold assumption here, however, both reports were from using this browser client.
  • Possibly an issue with textures?
  • Possibly V8 engine causing this?

Definitely some sort of weird rare problem. Goodluck debugging.


If someone is able to figure out how to reproduce this problem, and explain steps, I can fix it.

@ultraviolet-jordan ultraviolet-jordan added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Nov 8, 2024
@noted-shark
Copy link

I played around with this a bit and couldn't recreate it in-game, but if you modify the client to not render those model IDs, you get the same behaviour (can't path through, no red doorway line on minimap). I did notice that the basement in the witch's house has a set of gates that use the same model as the disappearing gates, which might be relevant as you have to open them to pass through during the quest.

Here's the original image for the previous report mentioned:
image

@ultraviolet-jordan
Copy link
Collaborator Author

I have a feeling that Chromes V8 engine is deciding to optimize code that is causing this.
The fix is you can try {} catch {} blocks of code to make V8 back out of optimizing that block of code.

The problem is I don't know what specific code it's optimizing that's causing this.

We had a bug before that was caused by this, and funny enough if I revert the fix, the problem doesn't even show up from before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants