Added DOC string for all the geometric objects. #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier only ndarray could be used as arguments for some geometric objects, for eg:- starting and ending point of Line object. Now any array_like object can be used.
because there arguments were already compatible with array_like objects.
kevkevinpal
approved these changes
May 3, 2020
manimlib/mobject/geometry.py
Outdated
| Returns | ||
| ----- | ||
| out : Arc object | ||
| An Arc object satisfying the specified requirements |
There was a problem hiding this comment.
maybe requirements -> parameters so it can match whats above same thing for the other blocks of comments
There was a problem hiding this comment.
Should I make a new pull request changing requirements to parameters?
There was a problem hiding this comment.
Nah just making a commit and pushing to the existing branch should be sufficient
anooprh
pushed a commit
to anooprh/manim
that referenced
this pull request
Feb 14, 2021
* Migrate width/height/depth to properties * Fix examples * Fix typos * Import manim for doctests * Expect Square for doctests * Improve docs for width/height/depth properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DOC string for all the geometric objects.
Earlier only ndarray could be used as arguments for ArcBetweenPoints instance.
For eg:-
arc = ArcBetweenPoints(start = (1,2,0), end = (-2,-3,0), angle = 30 * DEGREES)would give error. But after the changes it works fine.
Thanks for contributing to manim!
Please ensure that your pull request works with the latest version of manim.
You should also include:
screenshots, gifs, commands, etc.) This is rather informal at the moment, but
the goal is to show us how you know the pull request works as intended.