-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest babel-preset-env (7.4.3) breaks this plugin #73
Comments
I am encountering the same issue. |
`[email protected]` has changed the format of how default exports are generated. This change makes sure the tests pass with the dependency upgraded. closes 59naga#73
`[email protected]` has changed the format of how default exports are generated. This change makes sure the tests pass with the dependency upgraded. closes 59naga#73
Managed to solve it in #74 |
#70 already solves it. |
They’ve been tweeted at and emailed, since October. |
@lijunle Are you able to review/merge/release? |
Hi, all. I found that I have NPM package management access. So, I directly merged #70 into my personal branch and publish it as version 1.0.1. Please check if it works. @59naga If you are reading this comment, maybe you want to merge back my personal branch to master. |
Follow up: version 1.0.1 is unpublished due to #76 |
Try version 1.0.2 to check if it mitigate this issue. |
@lijunle looks like this plugin don't work well with @babel/plugin-transform-modules-umd (or even rollup with babel plugin for that matter) umd module throws "Uncaught ReferenceError: module is not defined" in browser console. The same worked with babel 6 earlier. For autosize 4.0.3: babel 6 has,
But babel 7 has,
see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990458 for details. In the end, I removed add-module-exports plugin and used rollup to generate umd, which worked. Update: it looks like a known limitation of babel umd plugin babel/babel#10696 |
I believe this change in
babel-preset-env
babel/babel#9781 breaks this plugin. Re-create by upgradingbabel-preset-env
in this package and run the tests.I tried going through the code in order to find how to fix it but I didn't manage.
The text was updated successfully, but these errors were encountered: