Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use non-semver image tags #62

Open
dan-sullivan opened this issue Nov 26, 2023 · 4 comments
Open

Unable to use non-semver image tags #62

dan-sullivan opened this issue Nov 26, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@dan-sullivan
Copy link

Hi!
Due to the various semantic versioning checks for the image tags, you cannot use a non-semver compliant tag. Particularly Im trying to use the ai-beta tag.

e.g. this in deployments.yaml is a failure point.

          volumeMounts:
            - name: data
              mountPath: {{ if semverCompare ">=1.0" (.Values.image.tag | default .Chart.AppVersion) }}/home/node/.n8n{{ else }}/root/.n8n{{ end }}

And of course when attempting to deploy, this fails pointing out the tag isnt semver compliant. I realise these are non-production tags so would you be willing to support these?

@Vad1mo
Copy link
Member

Vad1mo commented Nov 26, 2023

Happy to accept PR. The suggest to ditch support for below version 1.0. we can bump the chart to 2.x and outline breaking change.

@disconn3ct
Copy link

FYI it doesn't accept pinned tags even if they are semver.
tag: "1.70.0@sha256:bf97d6fd51f543078cbefde90f38a248ba7e775c28b3a9ab42b3b08b388f826a" fails.

@Vad1mo
Copy link
Member

Vad1mo commented Nov 27, 2024

I have no problem

docker pull 8gears.container-registry.com/examples/hello-world:latest@sha256:65a579d1e76f280adb6ccb7340fc6a014057d1add5da562a9dffe1ea5f3dd741
8gears.container-registry.com/examples/hello-world@sha256:65a579d1e76f280adb6ccb7340fc6a014057d1add5da562a9dffe1ea5f3dd741: Pulling from examples/hello-world
d74bf3f073b8: Download complete 
801bfaa63ef2: Download complete 
d164bab334d5: Download complete 
Digest: sha256:65a579d1e76f280adb6ccb7340fc6a014057d1add5da562a9dffe1ea5f3dd741
Status: Downloaded newer image for 8gears.container-registry.com/examples/hello-world@sha256:65a579d1e76f280adb6ccb7340fc6a014057d1add5da562a9dffe1ea5f3dd741
8gears.container-registry.com/examples/hello-world:latest@sha256:65a579d1e76f280adb6ccb7340fc6a014057d1add5da562a9dffe1ea5f3dd741

I, however, see now the real issue, I'll create a patch ditching support for < 1.0

@Vad1mo Vad1mo added the bug Something isn't working label Nov 27, 2024
@disconn3ct
Copy link

Docker pull isn't how the chart parses that tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants