Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: This is harder than it seemed..
This PR explicitly adds support for Node v12+, in line with what json-schema-to-typescript supports. This change enables json-schema-to-typescript to switch to the latest version of json-schema-ref-parser, and away from our custom fork.
json-schema-to-typescript supports v12+ because 10% of Node users are still on v12-15 (vs. 88% who use v16+). This is a large enough set of users that we want to continue to support them.
To make this work, I:
unused-imports/no-unused-imports-ts
dependency. It is redundant because ESLint'sno-unused-vars
rule already covers unused imports.@typescript-eslint/parser
to the previous major version, since the current version requires Node v18+.jsdom
to v19, which is the last version that supports Node 12.If Github CI passes, this PR is safe to merge 🤞.