Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly support Node v12+ #335

Closed
wants to merge 1 commit into from
Closed

Conversation

bcherny
Copy link
Contributor

@bcherny bcherny commented Mar 2, 2024

Update: This is harder than it seemed..

This PR explicitly adds support for Node v12+, in line with what json-schema-to-typescript supports. This change enables json-schema-to-typescript to switch to the latest version of json-schema-ref-parser, and away from our custom fork.

json-schema-to-typescript supports v12+ because 10% of Node users are still on v12-15 (vs. 88% who use v16+). This is a large enough set of users that we want to continue to support them.

To make this work, I:

  1. Removed the unused-imports/no-unused-imports-ts dependency. It is redundant because ESLint's no-unused-vars rule already covers unused imports.
  2. Downgraded @typescript-eslint/parser to the previous major version, since the current version requires Node v18+.
  3. Downgraded jsdom to v19, which is the last version that supports Node 12.

If Github CI passes, this PR is safe to merge 🤞.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant