Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is it deliberate that you need math/ on the include path to build the math tests? #53

Open
enh-google opened this issue Jan 25, 2023 · 1 comment

Comments

@enh-google
Copy link

is it deliberate that you need math/ on the include path to build the math tests?

i'm guessing these should all have the leading test/ removed?

math/test/mathbench.c:#include "test/mathbench_wrappers.h"
math/test/mathbench.c:#include "test/mathbench_funcs.h"
math/test/ulp.c:#include "test/ulp_wrappers.h"
math/test/ulp.c:#include "test/ulp_funcs.h"

(worked around in the Android build for now by just adding math/ to the include path.)

@nsz-arm
Copy link
Contributor

nsz-arm commented Apr 6, 2023

it is because now math/test/foo.h is copied into build/include/test/foo.h and build/include is in the include path but build/include/test is not.

this is a bit weird, but the reason is to allow pl/math/test/foo.h to override math/test/foo.h when building test tools. i think we may need a nicer way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants