Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload to pypi #24

Open
spanezz opened this issue Mar 3, 2022 · 7 comments
Open

Upload to pypi #24

spanezz opened this issue Mar 3, 2022 · 7 comments
Assignees

Comments

@spanezz
Copy link
Contributor

spanezz commented Mar 3, 2022

The README.md lacks an "How to install Moncic-CI" section.

To write one, we should have at least one straightforward install procedure, like pip install moncic, for which we need to have Moncic-CI on PyPI, and a workflow to keep it up to date.

Is that something we can commit to doing, and if so, could you set it up, maybe with a PyPI account for ARPA-SIMC?

@spanezz spanezz changed the title Upload to pypi? Upload to pypi Mar 3, 2022
@anarcat
Copy link

anarcat commented Mar 3, 2022

at least having a pip install . would be a good start, there must be a way you deploy this right now no? :)

@spanezz
Copy link
Contributor Author

spanezz commented Mar 3, 2022

In my development system, I fakeroot debian/rules binary, and in our production systems we'll do the equivalent for Fedora. I guess we ought to have something for more mainstream users.

@anarcat do you have a link to some documentation to get pip install . to work?

@spanezz
Copy link
Contributor Author

spanezz commented Mar 3, 2022

I was about to say, I don't have pip set up in my system so I can't try it, but then I thought, this is Moncic-CI we're talking about, so:

$ monci shell -rw . fedora35
# dnf install pip
# pip install .

…and monci is available in $PATH.

Dependencies from setup.py don't seem to be automatically installed like that, though, so I still had to dnf install python3-pyyaml to make it work

@anarcat
Copy link

anarcat commented Mar 3, 2022 via email

@spanezz
Copy link
Contributor Author

spanezz commented Mar 3, 2022

Thanks! I've added install_requires and now it works 🎉

I've updated the installation instructions in the README accordingly

@edigiacomo
Copy link
Member

Is that something we can commit to doing, and if so, could you set it up, maybe with a PyPI account for ARPA-SIMC?

Currently we don't have a PyPI account but I think we could add the upload to PyPI to our deploy pipeline, we'll discuss it internally.

Maybe you already know it, but you can install moncic-ci from the github repository without cloning it

$ python3 -mvenv env

# Install v0.1
$ env/bin/pip install git+https://github.com/arpa-simc/[email protected]

# Install main branch
$ env/bin/pip install git+https://github.com/arpa-simc/moncic-ci.git@main

# Install from requirements.txt
$ echo git+https://github.com/arpa-simc/[email protected] > requirements.txt
$ env/bin/pip install -r requirements.txt

@edigiacomo
Copy link
Member

I have created a PyPI account (https://pypi.org/user/arpaesimc/). As soon as we have a new version of moncic-ci, I will publish it on PyPI and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants