You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I understood correctly, EquivalentCircuits.jl is currently not capable of excluding certain types of elements when generating ECMs, which is why we exclude ideal capacitors (since they're unphysical) after ECMs are generated. This is suboptimal because we in each iteration a fraction of the generated ECMs are already invalid.
I'm not sure if this is a bug in EquivalentCircuits.jl, or it's just a nonexistent feature. Either way, we can work with the developers and propose a patch/feature.
The text was updated successfully, but these errors were encountered:
Seems to have been a bug in EquivalentCircuits.jl and has been recently fixed in MaximeVH/EquivalentCircuits.jl@7982802. Once tested, will close this issue.
@SaraQiuyuShi Would you be able to test and see if this has been solved indeed? You can try passing terminals="RCP", terminals="RP", and terminals="RC" and see if it matches the outputed ECMs. Thanks! You need to do a force update though to get the latest EquivalentCircuits.jl. First, do a git pull under AutoEIS cloned repo, then remove the Julia environment folder using rm -rf PATH_TO_julia_env_FOLDER. It's usually located under your virtual environment. First find where your Python virtualenv is located: which python, then it should be directly located under the virtualenv folder.
If I understood correctly, EquivalentCircuits.jl is currently not capable of excluding certain types of elements when generating ECMs, which is why we exclude ideal capacitors (since they're unphysical) after ECMs are generated. This is suboptimal because we in each iteration a fraction of the generated ECMs are already invalid.
I'm not sure if this is a bug in EquivalentCircuits.jl, or it's just a nonexistent feature. Either way, we can work with the developers and propose a patch/feature.
The text was updated successfully, but these errors were encountered: