Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude ideal capacitors at EquivalentCircuits.jl level #1

Open
ma-sadeghi opened this issue Sep 11, 2023 · 2 comments
Open

Exclude ideal capacitors at EquivalentCircuits.jl level #1

ma-sadeghi opened this issue Sep 11, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ma-sadeghi
Copy link
Collaborator

If I understood correctly, EquivalentCircuits.jl is currently not capable of excluding certain types of elements when generating ECMs, which is why we exclude ideal capacitors (since they're unphysical) after ECMs are generated. This is suboptimal because we in each iteration a fraction of the generated ECMs are already invalid.

I'm not sure if this is a bug in EquivalentCircuits.jl, or it's just a nonexistent feature. Either way, we can work with the developers and propose a patch/feature.

@ma-sadeghi ma-sadeghi added the enhancement New feature or request label Sep 11, 2023
@ma-sadeghi
Copy link
Collaborator Author

Seems to have been a bug in EquivalentCircuits.jl and has been recently fixed in MaximeVH/EquivalentCircuits.jl@7982802. Once tested, will close this issue.

@ma-sadeghi
Copy link
Collaborator Author

@SaraQiuyuShi Would you be able to test and see if this has been solved indeed? You can try passing terminals="RCP", terminals="RP", and terminals="RC" and see if it matches the outputed ECMs. Thanks! You need to do a force update though to get the latest EquivalentCircuits.jl. First, do a git pull under AutoEIS cloned repo, then remove the Julia environment folder using rm -rf PATH_TO_julia_env_FOLDER. It's usually located under your virtual environment. First find where your Python virtualenv is located: which python, then it should be directly located under the virtualenv folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant