Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter fitter is not robust #83

Open
ma-sadeghi opened this issue Feb 5, 2024 · 1 comment
Open

Parameter fitter is not robust #83

ma-sadeghi opened this issue Feb 5, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ma-sadeghi
Copy link
Collaborator

ma-sadeghi commented Feb 5, 2024

fit_circuit_parameters fails at a moderate rate (maybe ~50% of the times). Currently, all our functions take in initial guess as an input argument, so it's not exactly breaking our stuff. But, for the cases where the user doesn't provide it, it relies on our fit_circuit_parameters, so they don't get an answer ~50% of the time.

Some possible solutions:

  • Run circuit fitter multiple times and choose the best (fit_circuit_parameters already accepts iters, so it's easy to implement)
  • Use a different circuit fitter (EquivalentCircuits.jl has a parameteroptimization, which I haven't tested thoroughly. There's also ImpedanceFitter)
  • Write one from scratch (I've already talked to a lead developer at Julia's SciML ecosystem, and they have a package that "seems" to be much faster than our Python solutions, so we can brute-force our way out of a bad guess, i.e., running the optimizer for hundreds of times without worrying too much about the time it takes)
@ma-sadeghi ma-sadeghi added the enhancement New feature or request label Feb 5, 2024
@ma-sadeghi
Copy link
Collaborator Author

We have a brand new circuit fitter (#90), which addresses this issue to some extent, but let's keep this open for a while until we're convinced that the new circuit fitter meets our needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant