Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: JingoC/WebDavServer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: AcidRaZor/WebDavServer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 7 files changed
  • 2 contributors

Commits on Dec 22, 2023

  1. Update Dockerfile:

    - Updated to .NET 7 images as project changed to use .NET 7 (from .NET 6)
    - Fixed COPY where it was copying WebDavService.Application CSPROJ that doesn't exist (or was renamed previously)
    AcidRaZor committed Dec 22, 2023
    Copy the full SHA
    9741952 View commit details
  2. - Instead of using First() or Last(), changed it to use the index ins…

    …tead to get rid of some unnecessary overhead (nitpicky I know)
    
    - Made the isDirectory check more reliable, found that in a WebDAV environment (Windows PC mapped drive to server), it picked up requests as not being a directory, causing some issues as the actual request (path) didn't end with "/" from GetPath() on the entry-point
    - Added an if-check to check if the item is, in fact, a directory before removing it from the list of directories. This made navigation possible to the last most child directory, otherwise it would show nothing
    AcidRaZor committed Dec 22, 2023
    Copy the full SHA
    8f3054a View commit details
  3. Copy the full SHA
    c33961e View commit details
  4. - Fixed an issue where, when running MKCOL, a PROPFIND check is done …

    …first to see if the directory exists, if it didn't gave an error because the database is expected to always return a value
    AcidRaZor committed Dec 22, 2023
    Copy the full SHA
    5fbc307 View commit details
  5. - Fixes an issue where an exception is thrown when propertiesList is …

    …empty. This happens when the directory or file doesn't exist. As part of the sequence (maybe specific to Windows mapped drives), it does a PROPFIND before running MKCOL/Get etc.
    AcidRaZor committed Dec 22, 2023
    Copy the full SHA
    5679637 View commit details
  6. - Fixed an issue where an exception was thrown that's unhandled in th…

    …e WebDAV response when an item doesn't exist. PROPFIND runs before MKCOL so it's important not to throw an exception in this sequence
    AcidRaZor committed Dec 22, 2023
    Copy the full SHA
    ee8bc93 View commit details
  7. - Changed PROPFIND to be an IActionResult to return 404 NotFound when…

    … requesting dumb windows files (Usually through Mapped Drive on Windows machines)
    AcidRaZor committed Dec 22, 2023
    Copy the full SHA
    57e174c View commit details
  8. - Fixed an issue where the RegEx ignored valid filenames. Important w…

    …hen Windows, by default, creates "New Folder" for you to rename when creatng. This should be cross-platform compatible.
    AcidRaZor committed Dec 22, 2023
    Copy the full SHA
    7f92ef2 View commit details
  9. - Fixed an issue where, it's checking the parent Id when getting the …

    …directory info instead of the actual directory referenced
    AcidRaZor committed Dec 22, 2023
    Copy the full SHA
    63b789c View commit details
  10. Copy the full SHA
    a9c554a View commit details
  11. Update ReadMe.md

    AcidRaZor authored Dec 22, 2023
    Copy the full SHA
    0647bde View commit details
  12. Copy the full SHA
    808e856 View commit details
  13. - Fixes an issue on directory rename where it was referencing the par…

    …ent instead of the directory being renamed
    
    - Updated Name to match Title
    AcidRaZor committed Dec 22, 2023
    Copy the full SHA
    21fc159 View commit details
Loading