Bank Accounts Wave 3 + Optional #61

dezshino · 2015-10-11T01:14:50Z

Completed Wave 3 Primary Requirements + optionals

Created CheckingAccount class
Created SavingsAccount class
Created MoneyMarketAccount class

…o Savings class

… in CheckingAccount Class

…arket.rb file

…s method, start of MoneyMarket withdraw method

kariabancroft · 2015-10-27T05:28:52Z

bankaccounts.rb

      end
+    return @balance


Nice job moving the return to outside of the if statement since it applies to both conditions

kariabancroft · 2015-10-27T05:38:22Z

Nice job with this. You made good use of super as well as a few constants.

kariabancroft and others added 14 commits October 8, 2015 11:13

Add wave 3

b79bdfe

Merge remote-tracking branch 'upstream/master' into dfcp/master

a69eb2e

Add SavingAccounts class into savings.rb file

adbada6

Add CheckingAccounts class inchecking.rb

5947081

Add bank.rb file to require all bank files, and add withdraw method t…

7f3283a

…o Savings class

Add initialize and withdraw methods for SavingsAccount class

0c8a748

Adds add_interest method to SavingsAccount class

18ecd24

Update withdraw and add withdraw_using_check and reset_checks methods…

5e3b7da

… in CheckingAccount Class

Improve withdraw_using_check method

4d4e789

Complete Wave 3 Primary and create MoneyMarketAccount class in moneym…

2709c44

…arket.rb file

Fix MoneyMarketAccount and initialize account

d1feeb9

Fix SavingsAccount withdraw method, add MoneyMarket reset transaction…

c853854

…s method, start of MoneyMarket withdraw method

Add/complete withdraw method to MoneyMarket class

23ab329

Complete MoneyMarket Account

aa012fd

kariabancroft reviewed Oct 27, 2015
View reviewed changes

bankaccounts.rb

end

return @balance

Copy link

kariabancroft Oct 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job moving the return to outside of the if statement since it applies to both conditions

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bank Accounts Wave 3 + Optional #61

Bank Accounts Wave 3 + Optional #61

dezshino commented Oct 11, 2015

kariabancroft Oct 27, 2015

kariabancroft commented Oct 27, 2015

Bank Accounts Wave 3 + Optional #61

Are you sure you want to change the base?

Bank Accounts Wave 3 + Optional #61

Conversation

dezshino commented Oct 11, 2015

kariabancroft Oct 27, 2015

Choose a reason for hiding this comment

kariabancroft commented Oct 27, 2015