Ash/master #75
Open
Ash/master #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you haven't already worked on wave 3 of this one, I definitely think that is something you should attempt. There are some important concepts covered there that i'd really like you to be able to practice. |
| @@ -40,16 +41,24 @@ def deposit (deposit_amount) | |||
| def self.all | |||
There was a problem hiding this comment.
On lines 29-31 above, since you have an instance variable called balance and an attr_accessor for that instance variable on line 6, this method is not doing anything additional and can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified wave 2, wrote self.all and self.find methods.