Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using SPELLS_CHANGED event #12

Open
mbattersby opened this issue Sep 9, 2021 · 1 comment
Open

Stop using SPELLS_CHANGED event #12

mbattersby opened this issue Sep 9, 2021 · 1 comment

Comments

@mbattersby
Copy link
Contributor

SPELLS_CHANGED is no longer a rare event. Whether by bug or design in Torghast it is being triggered every 0.5 seconds.

See AdiAddons/AdiButtonAuras#388

This is far too often for a complete rescan of the spellbooks.

@Rainrider
Copy link
Member

The event is used to be seldom enough with some rare occasions when it was spammer. I recall it fired more often for warlocks probably because of some pet mechanic. Torghast seems to be an odd one in this regard. From my test the spam starts when the extra ability becomes empowered and only while this state persist. Once the player uses the ability, the spam stops until the next empowerment. I will test more why a change is reported by LSB in this case because this triggers rules rebuild for ABA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants