Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shopware store version vs. composer installation #571

Open
0x4 opened this issue Oct 23, 2024 · 3 comments
Open

shopware store version vs. composer installation #571

0x4 opened this issue Oct 23, 2024 · 3 comments

Comments

@0x4
Copy link

0x4 commented Oct 23, 2024

If the plugin is installed via composer with the shopware-store url

composer require store.shopware.com/adyenpaymentshopware6 

then the plugin is listed 2 times in the plugin:list command

Shopware Plugin Service
=======================

 -------------------------------------- ------------------------------------------ --------------------------------------------------------- --------- ----------------- ----------------------- ----------- -------- ------------- ----------------------
  Plugin                                 Label                                      Composer name                                             Version   Upgrade version   Author                  Installed   Active   Upgradeable   Required by composer
 -------------------------------------- ------------------------------------------ --------------------------------------------------------- --------- ----------------- ----------------------- ----------- -------- ------------- ----------------------
  AdyenPaymentShopware6                  Adyen Payment                              store.shopware.com/adyenpaymentshopware6                  4.1.3                       Adyen                   Yes         Yes      No            Yes
... 
 AdyenPaymentShopware6                                                                                                                       4.1.3                                               No          No                     Yes

Seems that this is not causing any problems, but looks wrong...
I think the problem is, that the composer version contains a vendor directory with a composer/installed.php file and composer loads this too

Versions
Shopware version: 6.6.7.0
Plugin version: 4.1.3

To Reproduce
Install the plugin via composer

Expected behavior
plugin:list shows the adyen plugin only once

@adyen-integrations-support

Hello @0x4,

Thank you for reaching out to us regarding this issue,

Please note that we attempted to reproduce the reported issue in a local environment but we were unsuccessful.
image
After executing bin/console plugin:list command, the plugin is listed only once, as evidenced by the screenshot above. We tried with PHP8.2 and 8.3 but the result was the same.

Could it be possible that you previously installed the Adyen plugin via zip, uninstalled it, and then installed the Adyen plugin with composer?

Could you try to reproduce the issue on your end again and let us know if you can do so?

Thank you,

Kind regards.

@0x4
Copy link
Author

0x4 commented Nov 15, 2024

Hello,

strange. unfortunately at the moment I have not the time to reproduce it in a fresh installation.
no we always had the composer installation - never used the zip in that project. In the plugin table in the database the entry is also only once.

Have you also called
bin/console plugin:refresh ?

What I can say:
if i delete this file

vendor/store.shopware.com/adyenpaymentshopware6/vendor/composer/installed.php

then the second entry in plugin:list is gone. And this file is part of the plugin - tried with a fresh composer install after deleting the vendor folder completely.

KR

@adyen-integrations-support

Hello @0x4,

Thank you for the feedback.

Note that our team was able to reproduce the issue after running plugin:refresh command after the installation.

Our team will proceed with fixing the issue.

We will let you know as soon as we have some valid information to share.

Kind regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants