Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endowments must be more permissive #36

Open
erights opened this issue Aug 23, 2019 · 1 comment
Open

Endowments must be more permissive #36

erights opened this issue Aug 23, 2019 · 1 comment

Comments

@erights
Copy link
Member

erights commented Aug 23, 2019

At

// todo: allow modifications when target.hasOwnProperty(prop) and it

is the todo comment at the beginning of the proxy's set trap. This todo must now be done, in order for our translation of module live bindings to work. Attn @michaelfig

This undone todo has gotten in the way of sensible uses by @kumavis , though @kumavis is not blocked on this.

If endowments contain accessor properties, we must transfer those accessor properties to the scopeTarget, rather than copying its current value into a data property. Thus, we must avoid composing the endowments or the scopeTarget using ... as that has get/set semantics, rather than getOwnPropertyDescriptors/defineProperties semantics.

@michaelfig
Copy link
Member

Thanks, this is now on my radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants