You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// todo: allow modifications when target.hasOwnProperty(prop) and it
is the todo comment at the beginning of the proxy's set trap. This todo must now be done, in order for our translation of module live bindings to work. Attn @michaelfig
This undone todo has gotten in the way of sensible uses by @kumavis , though @kumavis is not blocked on this.
If endowments contain accessor properties, we must transfer those accessor properties to the scopeTarget, rather than copying its current value into a data property. Thus, we must avoid composing the endowments or the scopeTarget using ... as that has get/set semantics, rather than getOwnPropertyDescriptors/defineProperties semantics.
The text was updated successfully, but these errors were encountered:
At
realms-shim/src/scopeHandler.js
Line 92 in ac709c7
is the todo comment at the beginning of the proxy's
set
trap. This todo must now be done, in order for our translation of module live bindings to work. Attn @michaelfigThis undone todo has gotten in the way of sensible uses by @kumavis , though @kumavis is not blocked on this.
If endowments contain accessor properties, we must transfer those accessor properties to the scopeTarget, rather than copying its current value into a data property. Thus, we must avoid composing the endowments or the scopeTarget using
...
as that has get/set semantics, rather than getOwnPropertyDescriptors/defineProperties semantics.The text was updated successfully, but these errors were encountered: