Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using analog quantity to control wled speed, the speed cannot change smoothly. Why? #4313

Open
1 task done
czweb opened this issue Nov 24, 2024 · 4 comments
Open
1 task done
Labels
backburner low priority compared to other issues enhancement

Comments

@czweb
Copy link

czweb commented Nov 24, 2024

What happened?

When using analog quantity to control wled speed, the speed cannot change smoothly. Why?
set2

Video:
https://www.youtube.com/shorts/9PZYwQT0Qoc
set1

To Reproduce Bug

using analog

Expected Behavior

Just like stepping on the accelerator, it feels like stepless speed regulation and should not jump

Install Method

Binary from WLED.me

What version of WLED?

=WLED 0.13.4

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@czweb czweb added the bug label Nov 24, 2024
@czweb
Copy link
Author

czweb commented Nov 24, 2024

The speed will also jump when you use wled web page to adjust the speed, or control the speed through node-red or HomeAssistant. The jump looks like starting the playback from the beginning, and it cannot be infinitely changed like driving a car.

@DedeHai
Copy link
Collaborator

DedeHai commented Nov 24, 2024

Smooth speed transitions are not implemened. Also it depends on how the FX handles speed changes, different effects can react differently to a speed change

@softhack007
Copy link
Collaborator

softhack007 commented Nov 24, 2024

We have almost 200 effects and all of them handle their progress calculations individually. Some use time = strip.now / (256 - SEGENV.speed), which makes them jump when you change the speed slider. It has always been like this.

There are other effects that require a delay between frames, and the delay is controlled by SEGENV.speed. so there is no generic solution - we'd need to comb through more than 200 effects, and each effect would needs it's own special solution. Some effects even use "speed" with a completely different meaning - like Lissajous (phase angle), GEQ (amount of fade), Gravimeter (delay of peak indicator), etc.

I don't see when/how we could find the time and people to address this topic. If you have a special effect in mind and you know how to change the effect source code, please feel free to contribute via pull request (PR).

@czweb
Copy link
Author

czweb commented Nov 24, 2024

Smooth speed transitions are not implemened. Also it depends on how the FX handles speed changes, different effects can react differently to a speed change

Thank you. It turns out that different effects will react differently to speed changes.
Not smooth: Chase, Lighthouse, Loading, TWODots
Smooth: Finally chose "meteor smooth"

@softhack007 softhack007 added enhancement backburner low priority compared to other issues and removed bug labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backburner low priority compared to other issues enhancement
Projects
None yet
Development

No branches or pull requests

3 participants