Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Missing in union attribute types #58

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

slwu89
Copy link
Member

@slwu89 slwu89 commented Sep 27, 2023

Mainly, adds support for attribute types which are union types including Missing. This entails adding specialized methods for preimage to deal with this case, as the usual == comparison doesn't work with the singleton object missing.

The cursed case where an attribute type is something like Union{Nothing,Missing,...} will still not work, but I think that is ok.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9d9c019) 89.61% compared to head (07fb97d) 89.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   89.61%   89.93%   +0.32%     
==========================================
  Files          12       12              
  Lines        1078     1083       +5     
==========================================
+ Hits          966      974       +8     
+ Misses        112      109       -3     
Files Coverage Δ
src/ColumnImplementations.jl 91.11% <100.00%> (+0.20%) ⬆️
src/PreimageCaches.jl 78.43% <100.00%> (+1.83%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sean! One small comment to simplify the logic.

src/PreimageCaches.jl Outdated Show resolved Hide resolved
@slwu89 slwu89 requested a review from epatters September 27, 2023 23:46
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sean, looks great!

@epatters epatters merged commit 1655674 into AlgebraicJulia:main Sep 28, 2023
@slwu89 slwu89 deleted the slwu89/convert branch September 28, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants