-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(showcase): use marked and prismjs to highlight the code #2436
Open
fpaul-1A
wants to merge
1
commit into
main
Choose a base branch
from
feat/showcase-prism
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
New feature or request
project:@o3r/showcase
project:new-version-gh-action
labels
Nov 8, 2024
fpaul-1A
force-pushed
the
feat/showcase-prism
branch
3 times, most recently
from
November 12, 2024 09:27
84f226e
to
c055f7e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
fpaul-1A
force-pushed
the
feat/showcase-prism
branch
2 times, most recently
from
November 12, 2024 10:35
219c074
to
7b7eb1d
Compare
sdo-1A
reviewed
Nov 12, 2024
apps/showcase/e2e-playwright/sanity/screenshots/visual-sanity.e2e.ts/chromium/localization.png
Outdated
Show resolved
Hide resolved
sdo-1A
reviewed
Nov 12, 2024
...showcase/e2e-playwright/sanity/screenshots/visual-sanity.e2e.ts/chromium/dynamic-content.png
Outdated
Show resolved
Hide resolved
fpaul-1A
force-pushed
the
feat/showcase-prism
branch
from
November 12, 2024 15:07
7b7eb1d
to
2968f35
Compare
kpanot
reviewed
Nov 13, 2024
...se/e2e-playwright/sanity/screenshots/visual-sanity.e2e.ts/chromium/component-replacement.png
Outdated
Show resolved
Hide resolved
fpaul-1A
force-pushed
the
feat/showcase-prism
branch
2 times, most recently
from
November 14, 2024 11:02
acc9d88
to
cf19c15
Compare
cpaulve-1A
reviewed
Nov 15, 2024
fpaul-1A
force-pushed
the
feat/showcase-prism
branch
from
November 19, 2024 14:29
cf19c15
to
4bc6de7
Compare
sdo-1A
previously approved these changes
Nov 20, 2024
fpaul-1A
force-pushed
the
feat/showcase-prism
branch
2 times, most recently
from
November 25, 2024 14:18
9453462
to
e8a280c
Compare
matthieu-crouzet
previously approved these changes
Nov 26, 2024
kpanot
reviewed
Nov 27, 2024
fpaul-1A
force-pushed
the
feat/showcase-prism
branch
from
November 27, 2024 08:31
e8a280c
to
a1c247b
Compare
kpanot
reviewed
Nov 27, 2024
fpaul-1A
force-pushed
the
feat/showcase-prism
branch
from
November 27, 2024 14:01
a1c247b
to
47a594a
Compare
matthieu-crouzet
previously approved these changes
Nov 28, 2024
fpaul-1A
force-pushed
the
feat/showcase-prism
branch
2 times, most recently
from
November 29, 2024 14:12
312a830
to
c8ca0d1
Compare
sdo-1A
reviewed
Nov 29, 2024
apps/showcase/src/app/component-replacement/component-replacement.spec.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
force-pushed
the
feat/showcase-prism
branch
from
November 29, 2024 15:38
c8ca0d1
to
192faa6
Compare
sdo-1A
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Following #2414
Replace all usage of
highlight.js
toprismjs
Related issues
- No issue associated -