Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logarithmic depth buffer breaks godrays #9

Open
johnnyrainbow opened this issue Aug 7, 2024 · 1 comment
Open

Logarithmic depth buffer breaks godrays #9

johnnyrainbow opened this issue Aug 7, 2024 · 1 comment

Comments

@johnnyrainbow
Copy link

Hey, awesome work. One issue I found is that setting the renderer logarithmic depth buffer breaks the godrays completely
var renderer = new WebGLRenderer({

 logarithmicDepthBuffer: true,

}

@Ameobea
Copy link
Owner

Ameobea commented Aug 30, 2024

Hi,

I made some changes that I think should work to add support for log depth buffers. Things looked mostly right when I tested in most scenes, but some didn't work correctly. I'm not sure what the issue is and depending on your scene/camera configuration, things may or may not work for you.

If you're still working on whatever it was that made you seek log depth support for this library, could you give it a try with version 0.7.1 and let me know if it's working for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants