Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection String Secret #13

Open
brettrowberry opened this issue Dec 27, 2020 · 2 comments
Open

Connection String Secret #13

brettrowberry opened this issue Dec 27, 2020 · 2 comments
Labels
question Further information is requested

Comments

@brettrowberry
Copy link

How should I manage a connection string with a secret?

@AngelMunoz AngelMunoz added the question Further information is requested label Dec 27, 2020
@AngelMunoz
Copy link
Owner

AngelMunoz commented Dec 27, 2020

there's no support for secrets right now if you're trying to run from CI or similar you could save the JSON file (with your secret) as an env var and "echo" it into the environment before starting the migration phase. Something like

echo $MIGRONDI_CONF > migrondi.json

which is what I do on GitLab's CI, for example with my gcloud service keys

...
deploy:
  stage: deploy
  script:
   ...
    - echo $GCP_SERVICE_KEY_STAGING > gcloud-service-key.json # Google Cloud service accounts
   ...

there are a couple of ways we can do this as well we can take them as cli arguments or try to read them from the environment

@AngelMunoz
Copy link
Owner

hey @brettrowberry I just recently switched to Argu and argu allows you to add an environment variable reader, so we could add it to the commands options or actually read it from the environment when trying to create a connection, let me know if you are interested in adding this or otherwise also let me know if I can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants