Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Artifact content rules (validity and compatibility) #98

Open
vsevel opened this issue Jul 29, 2022 · 5 comments
Open

Add support for Artifact content rules (validity and compatibility) #98

vsevel opened this issue Jul 29, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@vsevel
Copy link

vsevel commented Jul 29, 2022

We need to be able to set content rules (validity and compatibility) on the Artifact CRD.

This would look like:

apiVersion: artifact.apicur.io/v1alpha1
kind: Artifact
metadata:
  name: avro-example
spec:
  artifactId: pests-record
  name: pets
  description: "Avro record for Pet entity"
  type: AVRO
  contentRules:
    validity: ENABLED
    compatibility : ENABLED
  labels:
    - avro
    - kafka
  content: |
    {"namespace": "example.avro",
     "type": "record",
     "name": "Pet",
     "fields": [
         {"name": "name", "type": "string"},
         {"name": "holderId",  "type": ["int", "null"]},
         {"name": "type", "type": ["string", "null"]}
     ]
    }
@EricWittmann EricWittmann added the enhancement New feature or request label Aug 10, 2022
@vsevel
Copy link
Author

vsevel commented Oct 14, 2022

hello, any news on this? thanks.
cc @mpusg

@mpumd
Copy link

mpumd commented Oct 17, 2022

Hi All,

Other things, we can possibly push a invalid avro schema because of disabled rules. After activated rules, your system become inconsistent. @EricWittmann @jsenko You should check the schema on the activation of rule for example. Possibly a issue ?

@LittleWat
Copy link
Contributor

@mpusg You may use global configuration to enable the validation
Apicurio/apicurio-registry#803

@famarting is thinking to create a separate Rule CRD for this purpose. The reason is as follows:
#23 (comment)

So this issue should be closed...?

@vsevel
Copy link
Author

vsevel commented Nov 2, 2022

@famarting is thinking to create a separate Rule CRD for this purpose.

makes sens

So this issue should be closed...?

I would rather wait for this to materialize. thanks.

@vsevel
Copy link
Author

vsevel commented Mar 15, 2023

any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants