Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression in plane takeoff behaviour in 4.6 #28681

Open
tridge opened this issue Nov 19, 2024 · 2 comments · May be fixed by #28730
Open

regression in plane takeoff behaviour in 4.6 #28681

tridge opened this issue Nov 19, 2024 · 2 comments · May be fixed by #28730

Comments

@tridge
Copy link
Contributor

tridge commented Nov 19, 2024

in 4.6.x we have introduced a bug in takeoff handling. We are not correctly handling an incorrect yaw estimate on takeoff. This is demonstrated in the following flight using CMAC_South, so the plane is pointing approximately south, with COMPASS_USE disabled:
image
the plane is flying to a loiter location behind the pilot, which is extremely bad
here is the same test with 4.5.7:
image

logs here:
http://uav.tridgell.net/TakeoffError/

@menschel
Copy link
Contributor

menschel commented Nov 20, 2024

As reported following #28352 there are three observed regressions in takeoff behaviour.

  • The not excepted yaw reset by GPS leading to the course corrections mentioned above. EDIT: Not for Auto Takeoff Mission item, this turned out to be excessive crosswind deviation and takeoff does not track the path but only the heading.
  • The continuous use of 100% throttle after TKOFF_THR_MAX_T is exceeded until TKOFF_ALT or the mission items takeoff altitude is reached. Previously it fell back to TECS controlled throttle based on the pitch angle.
  • The level-off functionality can level out the plane below target altitude thus preventing takeoff to complete Issue Takeoff not completing under TKOFF_OPTIONS[0]=0 #28685 .

for reference ap460beta1_tkoff_issue.mp4 24-11-18_12-43-12.bin

@tridge tridge linked a pull request Nov 25, 2024 that will close this issue
@menschel
Copy link
Contributor

The YAW issue is not present in auto takeoff mission item.
Measurements are referenced in the PR for the items I mentioned.
#28776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants