Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency 2024 #6117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update dependency 2024 #6117

wants to merge 1 commit into from

Conversation

khancyr
Copy link
Contributor

@khancyr khancyr commented Jul 16, 2024

update theme to 2.0.0. need ArduPilot/sphinx_rtd_theme#22
-> this fix some small html and js errors
-> allow to use python 3.11 and recent docutil to generate html
update youtube plugin to latest version need ArduPilot/sphinxcontrib-youtube#6
-> fix the status_iterator warning
->fix privacy video link
-> don't generate thumbnails unless building for latex or pdf

raise docutil dependency to 0.20
raise sphinx version to 7.4.4

@khancyr khancyr force-pushed the update-dependency-2024 branch 2 times, most recently from 7c5e5a0 to f670f49 Compare July 16, 2024 10:56
@Hwurzburg
Copy link
Contributor

lots of seemingly unrelated changes

@khancyr khancyr force-pushed the update-dependency-2024 branch 2 times, most recently from 400192c to c5b41df Compare July 16, 2024 14:20
@khancyr
Copy link
Contributor Author

khancyr commented Jul 16, 2024

yes, it needs #6118 first as we got some recursive dependences. Current Sphinx build don't catch it but the new version is catching it.

@Hwurzburg
Copy link
Contributor

most of the files changed in this PR bear no relation to the title or stated intention in its description...please separate into a different PR

@khancyr
Copy link
Contributor Author

khancyr commented Jul 16, 2024

It needs the recursion fix PR otherwise it won't build and the two other PR. So this one should be the latest merged

@rmackay9
Copy link
Contributor

@khancyr I think maybe it would be good to remove the commit that is already included in #6118

@Hwurzburg
Copy link
Contributor

@khancyr have you tested this thoroughly?

@khancyr
Copy link
Contributor Author

khancyr commented Aug 29, 2024

I have build all wikis without issues reported.
I have check manually that each a opening and open random pages : No visibles diff with the current version, images are at same place and video too.
So that seems pretty safe.

For the build, it correct a bunch of issues and allow to build a bit faster this we can now disable some options that weren't used in our build !

Still need to be merged after the recursion , Youtube-contrib and theme update PRs, all three are needed to allow build with the new version.

@khancyr khancyr force-pushed the update-dependency-2024 branch 3 times, most recently from 8e27667 to ecfe275 Compare September 1, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants