Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more progress bars #311

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Include more progress bars #311

merged 1 commit into from
Dec 18, 2023

Conversation

teutoburg
Copy link
Contributor

This simply adds some tqdm wrappers around some of our main loops. Doesn't speed things up, but at least we'll have a better idea about how far it is. Also has the nice benefit of providing a total elapsed time (per loop).

@teutoburg teutoburg self-assigned this Dec 17, 2023
@teutoburg teutoburg added the enhancement New feature or request label Dec 17, 2023
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8c4a18b) 80.32% compared to head (77fa8d6) 80.32%.

Files Patch % Lines
scopesim/effects/spectral_trace_list.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           dev_master     #311   +/-   ##
===========================================
  Coverage       80.32%   80.32%           
===========================================
  Files             148      148           
  Lines           14902    14904    +2     
===========================================
+ Hits            11970    11972    +2     
  Misses           2932     2932           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg requested a review from hugobuddel December 17, 2023 11:26
Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Looks like rectify_traces() is not covered by tests, which we should do at some point. But it is in one of the notebooks, which is good enough now.

@teutoburg teutoburg merged commit a783dda into dev_master Dec 18, 2023
22 checks passed
@teutoburg teutoburg deleted the fh/tqdm branch December 18, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants