Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Pull Request template that reminds people to run the full test suite #169

Open
1 task
hugobuddel opened this issue Apr 13, 2024 · 0 comments
Open
1 task
Assignees

Comments

@hugobuddel
Copy link
Collaborator

Occasionally we merge a PR that breaks the notebooks. The notebooks are only ran in the CI when triggered manually, because otherwise they take too long.

We should add a Pull Request template that reminds people to run the full test suite before merging / before marking the PR as ready.

See https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

Something like:

  • I have ran the full test suite and all tests including the notebooks pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants