Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add METIS notebooks to the CI #93

Open
hugobuddel opened this issue Mar 14, 2023 · 1 comment
Open

Add METIS notebooks to the CI #93

hugobuddel opened this issue Mar 14, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation validation Cross-checking results with references

Comments

@hugobuddel
Copy link
Collaborator

Branch https://github.com/AstarVienna/irdb/tree/hb/runmetisnotebooksinci also runs the METIS notebooks in the CI.

(There is no PR yet, because the notebooks are skipped when automatically running the CI on a PR. Instead, manually trigger the action, then the notebooks are run.)

However, they fail, probably because they use too much memory. Using /usr/bin/time -v on my machine shows that https://github.com/AstarVienna/irdb/blob/dev_master/METIS/docs/example_notebooks/LSS_AGN-02_simulation.ipynb uses 13 GB of RAM, which seems to be over the github action limit.

I believe that is also the notebook that I cannot run on my 16 GB RAM laptop. There are probably more users with a similar laptop, so maybe it would be a better user experience if we make the notebook simpler.

@astronomyk what do you think?

@hugobuddel
Copy link
Collaborator Author

Increasing the spectral bandwidth by a factor 2 to 3.0e-3 reduced the memory footprint by a factor 2 as well, and doesn't seem to affect the plots noticibly. First with 1.5e-3:

agnplot

Then with 3e-3:

agnplot2

@teutoburg teutoburg added documentation Improvements or additions to documentation validation Cross-checking results with references labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation validation Cross-checking results with references
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants