Disble SourceDescriptionFitsKeywords for MICADO #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SourceDescriptionFitsKeywords still cause problems, see AstarVienna/ScopeSim_Templates#70 AstarVienna/ScopeSim_Templates#69
|
Tests fail because of https://github.com/AstarVienna/ScopeSim/pull/314/files#r1434844238 |
|
What's the status of this @hugobuddel ? I just realized that I never reacted to the review request here. Does this still fail? Should we merge it before making new packages? (even if we now only need a new version for METIS, this still requires a merge to master, so it might make sense to include that as well?) |
teutoburg
added
the
instrument-specific
|
Let's include it. I don't think we fixed this properly. Which is one of the reasons I prefer to use short source names without parameters. We should keep the ScopeSim Templates issues open probably. And maybe make some minimal examples that show the behavior. |
teutoburg
approved these changes
Feb 28, 2024
teutoburg
added
the
instrument definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SourceDescriptionFitsKeywords still cause problems, see AstarVienna/ScopeSim_Templates#70 AstarVienna/ScopeSim_Templates#69