Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gutenberg 18 #254

Open
fjorgemota opened this issue Apr 1, 2024 · 2 comments
Open

Update to Gutenberg 18 #254

fjorgemota opened this issue Apr 1, 2024 · 2 comments

Comments

@fjorgemota
Copy link
Member

fjorgemota commented Apr 1, 2024

As far as I know, we should probably just update the packages/dependencies.

@fullofcaffeine
Copy link
Contributor

fullofcaffeine commented Apr 1, 2024

FWIW, the latest version works well when Gutenberg 18-assets are enqueued in the WordPress env when the plugin is loaded. I think that's due to most core package's assets being extracted out using the DependencyExtractionPlugin, so the iso editor ends up using what's available at runtime, which are the versions published/packaged with GB v18.0.0.

If that's the case, that means we might delay the update to the iso editor, and updating the GB plugin should be enough for most cases, unless the interface changes drastically and the consuming code here breaks because of that (though that shouldn't happen unless we're using unstable APIs, I think).

That being said, I believe we should still aim to align the packages consumed here with the most recent versions available - this could probably be partially automated with renovate?

@fjorgemota
Copy link
Member Author

Yeah, I agree. I created this issue also as a way to track any possible incompatibilities, but, if they do not exist, then just updating the packages should be enough.

this could probably be partially automated with renovate?

I'm not sure. I usually align the versions with the versions present at the moment of the release. I'm not sure what's the best approach here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants