Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a new subscription endpoint to save to cache #48

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

s-amann
Copy link
Contributor

@s-amann s-amann commented Apr 9, 2024

What this PR does

Before this PR:
The endpoint did not exist

After this PR:
The endpoint exists, and requests to it will cache the payload

Jira: ARO-6310
Link to demo recording:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Deployment: The deployment process was considered and addressed if required
  • Testing: New code requires new unit tests.
  • Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
  • Customers: Is this change affecting customers? Is the release plan considered?

@s-amann s-amann marked this pull request as ready for review April 9, 2024 19:17
Copy link
Collaborator

@mbarnes mbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm surprised we can't generate the subscription structs with the autorest tool, but I don't see anything in /api/common-types from which to do so. Doesn't need to block initial support but would be a nice-to-have.

@s-amann s-amann merged commit 269405f into Azure:main Apr 9, 2024
4 checks passed
@s-amann s-amann deleted the adds-subscription-endpoint branch April 9, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants