-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert PyRIT Framework How to Guide to jupytext #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was fast! Thanks, @nina-msft
rdheekonda
approved these changes
Feb 21, 2024
…eing at top of file
…ikan/2180-convert-howto-jupytext
rlundeen2
approved these changes
Feb 21, 2024
dlmgary
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR converts the wiki page to Jupytext / Jupyter Notebook. It contains the min set of changes needed to create a notebook with Jupytext. There was some overlap with @rlundeen2's PR: #49 which is now merged.
Note: In converting to a Jupyter Notebook that passed, I modified the original Wiki content a bit to:
Tests
Documentation
Note: Need to coordinate with Marketing folks to redirect to this How To page instead of the one on the Wiki, then need to delete the Wiki page. @romanlutz is there any other redirection needed for this change?