Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage propagation leads to API change of DiskRestorePointData #5169

Open
Tracked by #5168
pshao25 opened this issue Nov 20, 2024 · 0 comments
Open
Tracked by #5168

Usage propagation leads to API change of DiskRestorePointData #5169

pshao25 opened this issue Nov 20, 2024 · 0 comments

Comments

@pshao25
Copy link
Member

pshao25 commented Nov 20, 2024

This is to track the known issue for the API change of DiskRestorePointData when we do the validation of Compute migrating to TypeSpec. The change is DiskRestorePointData is changed from output to roundtrip, which leads to new setter added to the properties of DiskRestorePointData.

The root cause is:
Previously, DiskRestorePoint extends ProxyOnlyResource, and itself is output only. Therefore, DiskRestorePointData is output.
But now, DiskRestorePoint extends common ProxyResource, which is shared across all the other resources that are roundtrip. Therefore, the roundtrip usage is propagated to DiskRestorePoint and DiskRestorePointData becomes roundtrip.

We won't have this issue for TypeSpec input. It only exists for swagger input. So we won't take action now.

@pshao25 pshao25 transferred this issue from Azure/typespec-azure Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant