-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix finding the ACA from Aspire9 deployment with custom ACA name #4490
Conversation
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like this is handling a case where the physical resource name differs from the logical resource name in the apphost model (since that is what serviceConfig.Name
is built from).
In that case, would we also need to use the updated physical resource name when using it in a binding expression like .url
?
I don't doubt that this fixes the issue, I'm just wondering if there are more dragons lurking here...
I think that's a conversation about that here: #4488 (reply in thread) What this PR is doing is not to fail when trying to fetch the name of the just-deployed ACA, which seems like a bug. Maybe the AppHost model should block setting the ACA name field or fail when you change it. But that's on the Aspire side @mitchdenny @davidfowl |
I don't think we should do this - in practice changing the name of the container app is something we don't support today and even with this change we still can't feel good about it, since things like the I think if this is something we want to support - we need some better way (maybe in the manifest) to communicate what the physical name of the container app is - so I think if we want to support this we need to design the full end to end feature first - doing this only helps somewhat. |
This PR makes azd to get the ACA name when setting a custom name in the AppHost.
The name is required only to display the endpoint.
fix: #4489