Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between consumer and producer config #459

Open
gvdwiele opened this issue Oct 10, 2023 · 1 comment
Open

Inconsistency between consumer and producer config #459

gvdwiele opened this issue Oct 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@gvdwiele
Copy link
Contributor

For the consumer, the KafkaTriggerAttribute parameter SslKeyPassword is being resolved using the ResolveSecureSetting when building the consumer. So it support the % syntax to get the SslKeyPassword value from the appsettings json.
See KafkaTriggerAttributeBindingProvider.cs line 105.

For the producer (output binding), the parameter is passed as-is without resolving the % syntax. So the password is not loaded from the configuration. See KafkaProducerFactory.cs line 131.

@jainharsh98
Copy link
Collaborator

Thanks for posting the issue @gvdwiele. Can you please create a PR to fix this? For reference similar changes have been made for other Ssl attributes here #430.

@jainharsh98 jainharsh98 added the enhancement New feature or request label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants