Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better fix for doi parsing #31

Open
NicoKiaru opened this issue Sep 5, 2024 · 1 comment
Open

Better fix for doi parsing #31

NicoKiaru opened this issue Sep 5, 2024 · 1 comment

Comments

@NicoKiaru
Copy link
Member

NicoKiaru commented Sep 5, 2024

I'm trying to retrieve the doi of the atlases from BrainGlobe here:

try:
self.dois.add(JString(self.atlas.metadata['citation'].split("doi.org/", 1)[1]))
except:
self.dois.add(JString("could not parse doi"))

However I had to catch an exception for the kim_mouse_idisco atlas (and probably others).

A better fix would be nice, I need to print and look at it.

@adamltyson
Copy link
Contributor

We don't enforce any kind of structure for the citation string, but we probably should. I've raised brainglobe/brainglobe-atlasapi#404 to track this. It probably won't be a quick fix unfortunately though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants