Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Add support for zombie options #284

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions doc/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ with support for 7 drivers out of the box:
the following parameters to avoid the validation error triggered by Guzzle:

* For ``Guzzle 4`` or later:

.. code-block:: yaml

default:
Expand All @@ -209,9 +209,9 @@ with support for 7 drivers out of the box:
goutte:
guzzle_parameters:
verify: false

* For ``Guzzle 3`` or earlier:

.. code-block:: yaml

default:
Expand Down Expand Up @@ -298,6 +298,9 @@ with support for 7 drivers out of the box:
zombie:
# Specify the path to the node_modules directory.
node_modules_path: /usr/local/lib/node_modules/
options:
# Optionally specify zombie specific options like:
waitDuration: '5s'

.. note::

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ public function configure(ArrayNodeDefinition $builder)
->scalarNode('server_path')->defaultNull()->end()
->scalarNode('threshold')->defaultValue(2000000)->end()
->scalarNode('node_modules_path')->defaultValue('')->end()
->arrayNode('options')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add useAttributeAsKey('name'). The value of the argument is not really useful (as we don't support XML config files, and YAML can define maps natively), but the call itself is necessary to ensure that keys are not lost when merging 2 configs together (and Behat relies on merging config between the default profile and other profiles for insrtance). Without this call, merging treats the array as a sequence, and so reindexes everything with numeric keys.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, I hope I understood what you wanted

Copy link

@aik099 aik099 Jul 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof has @berliner changed what you've requested? If so, then this PR can be merged.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof has @berliner changed what you've requested? If so, then this PR can be merged.

Copy link

@TerjeBr TerjeBr Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see in the code that it has been changed.
->useAttributeAsKey('name') is on line 48

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Looks good then.

->prototype('scalar')->end()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use 4 space for the indentation

->defaultValue(array())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

->defaultValue(array()) is useless. This is already the case for a prototyped array node

->end()
->end()
;
}
Expand All @@ -67,6 +71,7 @@ public function buildDriver(array $config)
$config['server_path'],
$config['threshold'],
$config['node_modules_path'],
$config['options'],
)),
));
}
Expand Down