Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on PHPUnit #37

Open
thewilkybarkid opened this issue Oct 15, 2015 · 1 comment · May be fixed by #38
Open

Remove dependency on PHPUnit #37

thewilkybarkid opened this issue Oct 15, 2015 · 1 comment · May be fixed by #38

Comments

@thewilkybarkid
Copy link

This has been raised before (#8), but I would like to see it revisited. PHPUnit assertions are currently used, but this involves pulling 17 (I think) other packages for just 6 assertions. We're not using PHPUnit in a project, so this is dramatically increasing the number of dependencies.

As PHPUnit doesn't provide its assertions in a standalone library, I think something else should be used, or they could just be replaced with internal ones (less convenient, but there's not that many).
@stof
Copy link
Member

stof commented Oct 15, 2015

Feel free to send a PR refactoring the context to stop using the PHPUnit assertions.
but make sure it behaves the same (i.e. valid cases and rejected cases are the same), and make sure failure messages are good too.

@thewilkybarkid thewilkybarkid linked a pull request Oct 19, 2015 that will close this issue
Open
@1ma 1ma mentioned this issue Feb 22, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependency on PHPUnit thewilkybarkid/WebApiExtension
2 participants
@stof @thewilkybarkid