-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guzzle configuration: verify #63
base: master
Are you sure you want to change the base?
Conversation
I want to be able to disable the certification verification for guzzle client
|
@@ -54,6 +54,9 @@ public function configure(ArrayNodeDefinition $builder) | |||
->scalarNode('base_url') | |||
->defaultValue('http://localhost') | |||
->end() | |||
->booleanNode('verify') | |||
->defaultValue(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we are supposed to test our own API, which is sometimes self-signed in dev, would it be a bad practice to set ->defaultValue(false)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think disabling the SSL cert check must be done on purpose, not by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple question about general good practices
It would be great if this is merged, I'm using a workaround and this could be quite helpful |
Can the maintainer please accept this PR? Its been open since 2016.. not cool to be honest. |
For now overriding config with reflection - but honestly when the maintainer wakes up - please merge PR. |
For now resorting to this:
|
I want to be able to disable the certification verification for guzzle client