Improvments #9
Open
Improvments #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Then the response header "Content-Type" should not be equal to "application" | ||
| """ | ||
| When I run "behat features/assert_headers.feature" | ||
| Then it should pass with: |
There was a problem hiding this comment.
Maybe this step (and other steps where command output is not inportant) could be simplified:
Then it should passI think there is no need to test progress formatter.
|
@stof / @adrienbrault What's status of this ? |
| */ | ||
| public function theResponseHeaderShouldBeEqualTo($header, $value) | ||
| { | ||
| Assertions::assertSame($this->response->getHeader($header), $value); |
There was a problem hiding this comment.
Maybe there should be an other assertion stating that the header should exist Assertions::assertTrue($this->response->hasHeader($header))
|
@adrienbrault : This P.R. contains many different things. Maybe splitting it would make it easier to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may add more things, but opening now to gather feedback!