behat 3 #13
behat 3 #13
Conversation
|
The branch-alias in the composer.json needs to be bumped to 2.0.x-dev, because this is a BC break for the extension itself (which is fine, as long as we advocate it properly) |
|
|
||
| namespace Behat\YiiExtension\Context; | ||
|
|
||
| class YiiContext implements YiiAwareContextInterface |
There was a problem hiding this comment.
IMO, we don't need this base class. Implementing the setter is easy enough
There was a problem hiding this comment.
I'd like to keep that class. Anybody who wants to integrate this context to his feature contexts should imo use hooks, i.e. BeforeScenario. Having the class ready for integration seems natural.
|
|
||
| $extensions = $container->getParameter('behat.extension.classes'); | ||
| // echo json_encode($container->getParameterBag()->all()); exit; |
|
|
||
| $basePath = $container->getParameter('paths.base'); | ||
|
|
||
| $extensions = $container->getParameter('extensions'); |
There was a problem hiding this comment.
this is used by the WUnitDriver registration, but the way it is done currently is wrong for MinkExtension 2. Registering a session is the wrong way. It should register a driver factory instead (look at the Symfony2Extension for an example)
| @@ -76,7 +85,7 @@ public function load(array $config, ContainerBuilder $container) | |||
| * | |||
| * @param ArrayNodeDefinition $builder | |||
| */ | |||
| public function getConfig(ArrayNodeDefinition $builder) | |||
| public function configure(ArrayNodeDefinition $builder) | |||
| { | |||
| $boolFilter = function ($v) { | |||
There was a problem hiding this comment.
this bool filter is really weird to me
|
This extension is alos registering the WUnitDriver for Mink, which has been marked as unmaintained (the WUnit implementation itself looked unmaintained last time I checked, and not even compatible with composer properly). Are you using it or no ? |
|
Not using wunit at all, removed it from package + updated readme. |
Hi, I've updated this extension for the latest Behat. Please have a look if this is something you'd like to merge.