Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation Problems #70

Open
Phi1983 opened this issue Jul 1, 2019 · 14 comments
Open

Installation Problems #70

Phi1983 opened this issue Jul 1, 2019 · 14 comments

Comments

@Phi1983
Copy link

Phi1983 commented Jul 1, 2019

Hey Daniel,
I have just installed PyHum, the installation worked without errors. However, when I try
python -c "import PyHum;PyHum.dotest()"
I get the following error:

Traceback (most recent call last):
File "", line 1, in
File "/home/philipp/anaconda2/envs/pyhum/lib/python2.7/site-packages/PyHum/init.py", line 60, in
from PyHum._pyhum_read import read
File "/home/philipp/anaconda2/envs/pyhum/lib/python2.7/site-packages/PyHum/_pyhum_read.py", line 72, in
import PyHum.pyread_single as pyread_single
File "PyHum/pyread_single.pyx", line 34, in init PyHum.pyread_single
File "/home/philipp/anaconda2/envs/pyhum/lib/python2.7/site-packages/PyHum/utils.py", line 37, in
import dask.array as da
File "/home/philipp/anaconda2/envs/pyhum/lib/python2.7/site-packages/dask/array/init.py", line 8, in
from .routines import (take, choose, argwhere, where, coarsen, insert,
File "/home/philipp/anaconda2/envs/pyhum/lib/python2.7/site-packages/dask/array/routines.py", line 256, in
@wraps(np.matmul)
File "/home/philipp/anaconda2/envs/pyhum/lib/python2.7/functools.py", line 33, in update_wrapper
setattr(wrapper, attr, getattr(wrapped, attr))
AttributeError: 'numpy.ufunc' object has no attribute 'module'

I installed the program on a Ubuntu 18.04 machine within conda, using your installation instruction.
Any ideas how to fix it?

Thanks
Philipp
@dbuscombe-usgs
Copy link
Member

Many, but no time to work on it. Please work on the issue and submit a PR. Pyhum is massively outdated and will get a radical overhaul in the winter

@Phi1983
Copy link
Author

Phi1983 commented Aug 14, 2019

Hey Daniel,
I tried, but I'm not familiar with python. I now working on a C++ solution and I managed already to read in the Humminbird files, thanks to your File-Format description.
At the moment, I stuck with the "pixel" to meter/range conversion. Do you know if there is the pulse length coded in the data files?
I have also a question about your solution in the code:

theta at 3dB in the horizontal

theta3dB = np.arcsin(c/(t*(f*1000)))
#resolution of 1 sidescan pixel to nadir
ft = (np.pi/2)*(1/theta3dB) #/ (f/455)

Shouldn't the across track resolution rather depend on the pulse length than on the opening angle of the transducer?

Best
Philipp

@dbuscombe-usgs
Copy link
Member

There is no pulse length info in the files as far as I can tell. You are correct that it should depend on the opening angle, but the above works, so I ran with it. Please suggest an improvement if you have one.

I am also VERY interested in your C++ implementation to read the files, if you are willing to share? That part is really slow in my python/cython implementation

I have been working on a new PyHum version that works in python 3 and built on modern scalable tech such as dask, xarray, but it will take months to complete because of lack of time

@Phi1983
Copy link
Author

Phi1983 commented Sep 18, 2019

Hey,
sorry for the late reply, I was on a cruise.
I don't have an idea for improvement.
I am willing to share, of course. I also wrote a new BDA which works quite well for my data.

Best, Philipp
Hum_IO&BDA.zip

@dbuscombe-usgs
Copy link
Member

Thanks so much for sharing this code. I will test it soon!

@dbuscombe-usgs
Copy link
Member

dbuscombe-usgs commented Oct 16, 2019 via email

@dbuscombe-usgs
Copy link
Member

dbuscombe-usgs commented Oct 16, 2019 via email

@dbuscombe-usgs
Copy link
Member

@Phi1983 please could you share the HumCoord.h file? I'm keen to see if I can incorporate your code. Thanks

@Phi1983
Copy link
Author

Phi1983 commented Nov 1, 2019

Hey Daniel, sorry again for the late reply. But things are also slow in my world :(
However, I managed to improve my code a little in the last weeks. It can know read the Humminbird file (from the Helix 5 series), remove the water column, make an intensity correction over range and saves the data to an ASCII File with easting northing intensity.
Here are all necessary files. It requires the free library Geographic.
To install the library on a ubuntu / debian machine just type:
sudo apt-get install libgeographic17
you can then compile the programm with:
g++ HumCoord.cpp HumIntCorrect.cpp HumIO.cpp HumSIBDA.cpp HumSI2ASCII.cpp -o HumSI2ASCII -lGeographic
then run the programm with for example:
./HumSI2ASCII R00001.DAT
it looks then for the necessary .SON and .IDX files in the subfolder R00001. That's the folderstructure my Humminbird stores the files.

Regarding the BDA, that's the bottom detection algorithm to remove the water column.

HumSI2ASCII.zip

Best,
Philipp

@dbuscombe-usgs
Copy link
Member

Excellent! Thanks so much. I got it to install on a debian based system but couldn't link to the apt version of GeographicLib, so I installed from source and updated my .bashrc so ld would find the path.

I can confirm that HumSI2ASCII also works with 998 series data. I will keep investigating but this is looking very useful and I would like to incorporate at least parts of it into the python version. May I? How should I credit you?

@Phi1983
Copy link
Author

Phi1983 commented Nov 10, 2019

Hey Daniel,
I'm glad that the code is helping you. And nice to know that it not only works for the Helix 5. Sure you can use it.

@cappelletto
Copy link

Hi all,
Sorry to bump this issue. I would love to give a try to PyHum but I have been facing installation issues under different setups/envs and most of them are related to libraries version (i have tried with virtual env, conda, and the git repo to no avail).
So, @dbuscombe-usgs do you have any expected date for the Python 3 port? I am fully aware about how difficult it can be under time-constrained situations, so my question is more out of curiosity.

I plan to keep digging on the installation error.

@Phi1983 I am looking at you C++ implementation, and I will definitely give a try!

Cheers,
Jose

@dbuscombe-usgs
Copy link
Member

I am sorry to say there has been no progress with this issue. My apologies. It is still the plan, eventually, but I cannot say for sure when it gets done. I am considering 'archiving' the PyHum repo until such time that I have time to work on it again

@cappelletto
Copy link

It is understandable. That is a time-resource intensive task!
Yet, I would like to thanks for the repository, it is really helpful to understand the underlying data format and the technique described in your article. I am trying to get some traction on using it for some post-processing pipelines. If we manage to further develop something on top of it, rest assured we will inform you.

Bests,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbuscombe-usgs @cappelletto @Phi1983