Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling through Inventory pages causes server lag #30

Open
SlyGuy89 opened this issue Oct 24, 2024 · 1 comment
Open

Scrolling through Inventory pages causes server lag #30

SlyGuy89 opened this issue Oct 24, 2024 · 1 comment

Comments

@SlyGuy89
Copy link

This may only apply to shops with a lot of items in the storage, but I've noticed that with some shops (that have 50+ pages of inventory) if I scroll through the pages rapidly it can severely affect the TPS of my server. I've seen the TPS drop as low as 10 when this happens.

This only seems to happen when spamming the next/previous page button. If I wait about 1 second between each press, there is no TPS drop.

Perhaps there's a way to put a cooldown on the scrolling buttons to reduce the impact on server performance.

*While on the subject:

This is also true for when players rapidly click on items to buy them. I recall that once upon a time this plugin had a delay/cooldown for how quickly you could click on an item to purchase it. It would be great if such a cooldown could be re-introduced, but made a part of the config.yml so Server Owners could decide on whether or not to utilize the delay, and how long the delay should be.

Thank you!

@Bestem0r
Copy link
Owner

Thank you for reporting this. Will be added in the next update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants