Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from DataDog:main #65

Merged
merged 21 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f0211e1
discovery: fix "too many open files" issue (#31957)
Yumasi Dec 10, 2024
5978d29
Refactor configuration to be able to pass a different SSH key per clo…
KevinFairise2 Dec 10, 2024
357c34f
[CWS] Lower ptrace tracee resolution issue log level (#31950)
spikat Dec 10, 2024
6eeac68
Remove flake designation from darwin-based dogstatsd tests (#31890)
ddrthall Dec 10, 2024
e476cb3
When running in CI, scrub e2e tests output to avoid leaking keys (#31…
KevinFairise2 Dec 10, 2024
04e117d
Post process e2e tests logs to make them more readable (#31615)
KevinFairise2 Dec 10, 2024
92cf9c4
feat(assign_owner): Send to correct channel and improve message (#31954)
chouetz Dec 10, 2024
03a3f1c
Support components multiple implementation for package name (#31551)
GustavoCaso Dec 10, 2024
0b42e2b
ci: Fix CODEOWNERS due to team split (#31896)
ddyurchenko Dec 10, 2024
385f25a
[NETPATH-371] Move common functions to separate package, create separ…
ken-schneider Dec 10, 2024
5ff3a47
[CWS] Move tags from cgroup to tags resolver (#31874)
lebauce Dec 10, 2024
b92624a
[CWS] fix overlayfs support on rocky 9.4 (#31948)
paulcacheux Dec 10, 2024
b629273
[fleet] add install_script e2e test setup (#31791)
raphaelgavache Dec 10, 2024
7f4316f
[CWS] Lower a noisy ptrace info log to debug (#31976)
spikat Dec 10, 2024
8b4888d
fix(kubernetesadmissionevents): add demultiplexer flushing in the uni…
wdhif Dec 10, 2024
6dea12d
[PLINT-578] [PLINT-589] Add platform integrations origins for q4 (#31…
sarah-witt Dec 10, 2024
90e7b91
usm: sowatcher: Extend paths support up to 220 characters (#31975)
guyarb Dec 10, 2024
ea648f3
[ASCII-2567] propagate the tagger component when building the OTLP pi…
GustavoCaso Dec 10, 2024
5b42c82
[ASCII-2588] Increase configsync test timeout to avoid flakiness on s…
pgimalac Dec 10, 2024
e58c70e
Update OTel Collector dependencies to v0.115.0 (#31900)
jackgopack4 Dec 10, 2024
e52d987
Turn tag/mapping conflict into an actual error. (#31673)
dplepage-dd Dec 10, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
/.gitlab/binary_build/system_probe.yml @DataDog/ebpf-platform @DataDog/agent-delivery
/.gitlab/binary_build/windows.yml @DataDog/agent-delivery @DataDog/windows-agent

/.gitlab/benchmarks/ @DataDog/agent-devx-infra @DataDog/apm-reliability-and-performance @DataDog/agent-apm
/.gitlab/benchmarks/ @DataDog/agent-devx-infra @DataDog/apm-ecosystems-performance @DataDog/agent-apm

/.gitlab/deploy_containers/ @DataDog/container-integrations @DataDog/agent-delivery
/.gitlab/deploy_dca/ @DataDog/container-integrations @DataDog/agent-delivery
Expand Down
1 change: 1 addition & 0 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ variables:
BUCKET_BRANCH: dev # path inside the staging s3 buckets to release to: 'dev', 'nightly', 'oldnightly', 'beta' or 'stable'
DEB_TESTING_S3_BUCKET: apttesting.datad0g.com
RPM_TESTING_S3_BUCKET: yumtesting.datad0g.com
INSTALLER_TESTING_S3_BUCKET: installtesting.datad0g.com
WINDOWS_TESTING_S3_BUCKET_A6: pipelines/A6/$CI_PIPELINE_ID
WINDOWS_TESTING_S3_BUCKET_A7: pipelines/A7/$CI_PIPELINE_ID
WINDOWS_BUILDS_S3_BUCKET: $WIN_S3_BUCKET/builds
Expand Down
1 change: 1 addition & 0 deletions .gitlab/JOBOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ publish_winget* @DataDog/windows-agent
powershell_script_deploy @DataDog/windows-agent
windows_bootstrapper_deploy @DataDog/windows-agent
qa_*_oci @DataDog/agent-delivery
qa_installer_script @DataDog/agent-delivery

# Deploy containers
deploy_containers* @Datadog/agent-delivery
Expand Down
14 changes: 14 additions & 0 deletions .gitlab/deploy_packages/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,17 @@ qa_installer_oci:
IMG_REGISTRIES: agent-qa
IMG_SOURCES: registry.ddbuild.io/ci/remote-updates/datadog-installer:pipeline-${CI_PIPELINE_ID}
IMG_DESTINATIONS: installer-package:pipeline-${CI_PIPELINE_ID}

qa_installer_script:
image: registry.ddbuild.io/ci/datadog-agent-buildimages/gitlab_agent_deploy$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
stage: deploy_packages
tags: ["arch:amd64"]
rules:
- !reference [.on_installer_or_e2e_changes]
- !reference [.manual]
needs:
- installer-install-scripts
before_script:
- ls $OMNIBUS_PACKAGE_DIR
script:
- $S3_CP_CMD --recursive --exclude "*" --include "install-*.sh" "$OMNIBUS_PACKAGE_DIR" "s3://${INSTALLER_TESTING_S3_BUCKET}/${CI_COMMIT_SHA}/scripts/"
5 changes: 5 additions & 0 deletions .gitlab/deploy_packages/oci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ include:
- datadog-package push registry.ddbuild.io/ci/remote-updates/${OCI_PRODUCT}:${VERSION} ${OMNIBUS_PACKAGE_DIR}/${OCI_PRODUCT}-${VERSION}.oci.tar
# This is used for E2E tests. Doesn't cost more than an additional tag to the registry.
- datadog-package push registry.ddbuild.io/ci/remote-updates/${OCI_PRODUCT}:pipeline-${CI_PIPELINE_ID} ${OMNIBUS_PACKAGE_DIR}/${OCI_PRODUCT}-${VERSION}.oci.tar
# Used for install scripts e2e tests
- datadog-package replicate-s3 registry.ddbuild.io/ci/remote-updates/${OCI_PRODUCT}:pipeline-${CI_PIPELINE_ID} us-east-1 ${INSTALLER_TESTING_S3_BUCKET} ${S3_PACKAGE} ${VERSION}
- datadog-package replicate-s3 registry.ddbuild.io/ci/remote-updates/${OCI_PRODUCT}:pipeline-${CI_PIPELINE_ID} us-east-1 ${INSTALLER_TESTING_S3_BUCKET} ${S3_PACKAGE} ${CI_COMMIT_SHA}
variables:
MAJOR_VERSION: 7

Expand All @@ -32,9 +35,11 @@ deploy_agent_oci:
needs: [ "agent_oci", "go_tools_deps"]
variables:
OCI_PRODUCT: "datadog-agent"
S3_PACKAGE: "agent-package"

deploy_installer_oci:
extends: ".deploy_packages_oci"
needs: [ "installer_oci", "go_tools_deps" ]
variables:
OCI_PRODUCT: "datadog-installer"
S3_PACKAGE: "installer-package"
41 changes: 36 additions & 5 deletions .gitlab/e2e/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,16 @@
- $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E profile >> ~/.aws/config || exit $?
- export AWS_PROFILE=agent-qa-ci
# Now all `aws` commands target the agent-qa profile
- $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_PUBLIC_KEY_PATH || exit $?
- touch $E2E_PRIVATE_KEY_PATH && chmod 600 $E2E_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_key_rsa > $E2E_PRIVATE_KEY_PATH || exit $?
# TODO: ADXT-768: Create new secret with different ssh key for the different cloud providers
# SSH Key retrieval for AWS
- $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AWS_PUBLIC_KEY_PATH || exit $?
- touch $E2E_AWS_PRIVATE_KEY_PATH && chmod 600 $E2E_AWS_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_key_rsa > $E2E_AWS_PRIVATE_KEY_PATH || exit $?
# SSH Key retrieval for Azure
- $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AZURE_PUBLIC_KEY_PATH || exit $?
- touch $E2E_AZURE_PRIVATE_KEY_PATH && chmod 600 $E2E_AZURE_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_key_rsa > $E2E_AZURE_PRIVATE_KEY_PATH || exit $?
# SSH Key retrieval for GCP
- $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_GCP_PUBLIC_KEY_PATH || exit $?
- touch $E2E_GCP_PRIVATE_KEY_PATH && chmod 600 $E2E_GCP_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_key_rsa > $E2E_GCP_PRIVATE_KEY_PATH || exit $?
# Use S3 backend
- pulumi login "s3://dd-pulumi-state?region=us-east-1&awssdk=v2&profile=$AWS_PROFILE"
# Setup Azure credentials. https://www.pulumi.com/registry/packages/azure-native/installation-configuration/#set-configuration-using-pulumi-config
Expand All @@ -35,15 +43,23 @@
KUBERNETES_MEMORY_REQUEST: 12Gi
KUBERNETES_MEMORY_LIMIT: 16Gi
KUBERNETES_CPU_REQUEST: 6
E2E_PUBLIC_KEY_PATH: /tmp/agent-qa-ssh-key.pub
E2E_PRIVATE_KEY_PATH: /tmp/agent-qa-ssh-key
# AWS SSH Key configuration
E2E_AWS_PUBLIC_KEY_PATH: /tmp/agent-qa-aws-ssh-key.pub
E2E_AWS_PRIVATE_KEY_PATH: /tmp/agent-qa-aws-ssh-key
E2E_KEY_PAIR_NAME: datadog-agent-ci-rsa
# Azure SSH Key configuration
E2E_AZURE_PUBLIC_KEY_PATH: /tmp/agent-qa-azure-ssh-key.pub
E2E_AZURE_PRIVATE_KEY_PATH: /tmp/agent-qa-azure-ssh-key
# GCP SSH Key configuration
E2E_GCP_PUBLIC_KEY_PATH: /tmp/agent-qa-gcp-ssh-key.pub
E2E_GCP_PRIVATE_KEY_PATH: /tmp/agent-qa-gcp-ssh-key
E2E_PIPELINE_ID: $CI_PIPELINE_ID
E2E_COMMIT_SHA: $CI_COMMIT_SHORT_SHA
E2E_OUTPUT_DIR: $CI_PROJECT_DIR/e2e-output
EXTERNAL_LINKS_PATH: external_links_$CI_JOB_ID.json
E2E_LOGS_PROCESSING_TEST_DEPTH: 1
script:
- inv -e new-e2e-tests.run --targets $TARGETS -c ddagent:imagePullRegistry=669783387624.dkr.ecr.us-east-1.amazonaws.com -c ddagent:imagePullUsername=AWS -c ddagent:imagePullPassword=$(aws ecr get-login-password) --junit-tar junit-${CI_JOB_ID}.tgz ${EXTRA_PARAMS} --test-washer
- inv -e new-e2e-tests.run --targets $TARGETS -c ddagent:imagePullRegistry=669783387624.dkr.ecr.us-east-1.amazonaws.com -c ddagent:imagePullUsername=AWS -c ddagent:imagePullPassword=$(aws ecr get-login-password) --junit-tar junit-${CI_JOB_ID}.tgz ${EXTRA_PARAMS} --test-washer --logs-folder=$E2E_OUTPUT_DIR/logs --logs-post-processing --logs-post-processing-test-depth=$E2E_LOGS_PROCESSING_TEST_DEPTH
after_script:
- $CI_PROJECT_DIR/tools/ci/junit_upload.sh
artifacts:
Expand Down Expand Up @@ -369,6 +385,20 @@ new-e2e-apm:
- EXTRA_PARAMS: --run TestVMFakeintakeSuiteUDS
- EXTRA_PARAMS: --run TestVMFakeintakeSuiteTCP

new-e2e-installer-script:
extends: .new_e2e_template
rules:
- !reference [.on_installer_or_e2e_changes]
- !reference [.manual]
needs:
- !reference [.needs_new_e2e_template]
- deploy_installer_oci
- qa_installer_script
variables:
TARGETS: ./tests/installer/script
TEAM: fleet
FLEET_INSTALL_METHOD: "install_script"

new-e2e-installer:
extends: .new_e2e_template
rules:
Expand All @@ -388,6 +418,7 @@ new-e2e-installer:
TARGETS: ./tests/installer/unix
TEAM: fleet
FLEET_INSTALL_METHOD: "install_script"
E2E_LOGS_PROCESSING_TEST_DEPTH: 2

new-e2e-installer-windows:
extends: .new_e2e_template
Expand Down
5 changes: 5 additions & 0 deletions .gitlab/e2e_install_packages/common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,23 @@
TARGETS: ./tests/agent-platform/install-script
TEAM: agent-delivery
EXTRA_PARAMS: --osversion $E2E_OSVERS --platform $E2E_PLATFORM --cws-supported-osversion $E2E_CWS_SUPPORTED_OSVERS --arch $E2E_ARCH --flavor $FLAVOR --no-verbose
E2E_LOGS_PROCESSING_TEST_DEPTH: 2 # We use a single test suite and run all the platforms test as subtest

.new-e2e_step_by_step:
stage: e2e_install_packages
variables:
TARGETS: ./tests/agent-platform/step-by-step
TEAM: agent-delivery
EXTRA_PARAMS: --osversion $E2E_OSVERS --platform $E2E_PLATFORM --cws-supported-osversion $E2E_CWS_SUPPORTED_OSVERS --arch $E2E_ARCH --flavor $FLAVOR
E2E_LOGS_PROCESSING_TEST_DEPTH: 2 # We use a single test suite and run all the platforms test as subtest

.new-e2e_script_upgrade7:
stage: e2e_install_packages
variables:
TARGETS: ./tests/agent-platform/upgrade
TEAM: agent-delivery
EXTRA_PARAMS: --osversion $E2E_OSVERS --platform $E2E_PLATFORM --arch $E2E_ARCH --flavor $FLAVOR
E2E_LOGS_PROCESSING_TEST_DEPTH: 2 # We use a single test suite and run all the platforms test as subtest
parallel:
matrix:
- START_MAJOR_VERSION: [5, 6, 7]
Expand All @@ -37,6 +40,7 @@
TARGETS: ./tests/agent-platform/persisting-integrations
TEAM: agent-delivery
EXTRA_PARAMS: --osversion $E2E_OSVERS --platform $E2E_PLATFORM --arch $E2E_ARCH --flavor $FLAVOR
E2E_LOGS_PROCESSING_TEST_DEPTH: 2 # We use a single test suite and run all the platforms test as subtest
script:
- DATADOG_AGENT_API_KEY=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $INSTALL_SCRIPT_API_KEY_ORG2 token) || exit $?; export DATADOG_AGENT_API_KEY
- inv -e new-e2e-tests.run --targets $TARGETS --junit-tar "junit-${CI_JOB_ID}.tgz" ${EXTRA_PARAMS} --src-agent-version 7 --test-washer
Expand All @@ -47,6 +51,7 @@
TARGETS: ./tests/agent-platform/rpm
TEAM: agent-delivery
EXTRA_PARAMS: --osversion $E2E_OSVERS --platform $E2E_PLATFORM --arch $E2E_ARCH
E2E_LOGS_PROCESSING_TEST_DEPTH: 2 # We use a single test suite and run all the platforms test as subtest
script:
- DATADOG_AGENT_API_KEY=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $INSTALL_SCRIPT_API_KEY_ORG2 token) || exit $?; export DATADOG_AGENT_API_KEY
- inv -e new-e2e-tests.run --targets $TARGETS --junit-tar "junit-${CI_JOB_ID}.tgz" ${EXTRA_PARAMS} --test-washer
6 changes: 4 additions & 2 deletions LICENSE-3rdparty.csv
Original file line number Diff line number Diff line change
Expand Up @@ -2436,12 +2436,12 @@ core,go.opentelemetry.io/collector/pdata/internal,Apache-2.0,Copyright The OpenT
core,go.opentelemetry.io/collector/pdata/internal/data,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/logs/v1,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/metrics/v1,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1development,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/trace/v1,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/pdata/internal/data/protogen/common/v1,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/pdata/internal/data/protogen/metrics/v1,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1development,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/pdata/internal/data/protogen/resource/v1,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/pdata/internal/data/protogen/trace/v1,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/pdata/internal/json,Apache-2.0,Copyright The OpenTelemetry Authors
Expand Down Expand Up @@ -2488,6 +2488,8 @@ core,go.opentelemetry.io/collector/receiver/receivertest,Apache-2.0,Copyright Th
core,go.opentelemetry.io/collector/receiver/scrapererror,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/receiver/scraperhelper,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/receiver/scraperhelper/internal/metadata,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/scraper,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/scraper/scrapererror,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/semconv/v1.16.0,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/semconv/v1.17.0,Apache-2.0,Copyright The OpenTelemetry Authors
core,go.opentelemetry.io/collector/semconv/v1.18.0,Apache-2.0,Copyright The OpenTelemetry Authors
Expand Down
6 changes: 3 additions & 3 deletions cmd/serverless-init/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ func setup(_ mode.Conf, tagger tagger.Component) (cloudservice.CloudService, *se
metricAgent := setupMetricAgent(tags, tagger)
metric.AddColdStartMetric(prefix, metricAgent.GetExtraTags(), time.Now(), metricAgent.Demux)

setupOtlpAgent(metricAgent)
setupOtlpAgent(metricAgent, tagger)

go flushMetricsAgent(metricAgent)
return cloudService, agentLogConfig, traceAgent, metricAgent, logsAgent
Expand Down Expand Up @@ -200,12 +200,12 @@ func setupMetricAgent(tags map[string]string, tagger tagger.Component) *metrics.
return metricAgent
}

func setupOtlpAgent(metricAgent *metrics.ServerlessMetricAgent) {
func setupOtlpAgent(metricAgent *metrics.ServerlessMetricAgent, tagger tagger.Component) {
if !otlp.IsEnabled() {
log.Debugf("otlp endpoint disabled")
return
}
otlpAgent := otlp.NewServerlessOTLPAgent(metricAgent.Demux.Serializer())
otlpAgent := otlp.NewServerlessOTLPAgent(metricAgent.Demux.Serializer(), tagger)
otlpAgent.Start()
}

Expand Down
6 changes: 3 additions & 3 deletions cmd/serverless/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func runAgent(tagger tagger.Component) {
wg.Add(3)

go startTraceAgent(&wg, lambdaSpanChan, coldStartSpanId, serverlessDaemon, tagger, rcService)
go startOtlpAgent(&wg, metricAgent, serverlessDaemon)
go startOtlpAgent(&wg, metricAgent, serverlessDaemon, tagger)
go startTelemetryCollection(&wg, serverlessID, logChannel, serverlessDaemon, tagger)

// start appsec
Expand Down Expand Up @@ -330,13 +330,13 @@ func startTelemetryCollection(wg *sync.WaitGroup, serverlessID registration.ID,
}
}

func startOtlpAgent(wg *sync.WaitGroup, metricAgent *metrics.ServerlessMetricAgent, serverlessDaemon *daemon.Daemon) {
func startOtlpAgent(wg *sync.WaitGroup, metricAgent *metrics.ServerlessMetricAgent, serverlessDaemon *daemon.Daemon, tagger tagger.Component) {
defer wg.Done()
if !otlp.IsEnabled() {
log.Debug("otlp endpoint disabled")
return
}
otlpAgent := otlp.NewServerlessOTLPAgent(metricAgent.Demux.Serializer())
otlpAgent := otlp.NewServerlessOTLPAgent(metricAgent.Demux.Serializer(), tagger)
otlpAgent.Start()
serverlessDaemon.SetOTLPAgent(otlpAgent)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func TestRunWithChan(t *testing.T) {

ch := make(chan time.Time, 1)
ch <- time.Now()
time.AfterFunc(100*time.Millisecond, cancel)
time.AfterFunc(500*time.Millisecond, cancel)
cs.runWithChan(ch)

require.True(t, called)
Expand Down
4 changes: 2 additions & 2 deletions comp/core/log/impl-systemprobe/systemprobe_logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-present Datadog, Inc.

// Package logimpl implements a component to handle logging internal to the agent for system-probe.
package logimpl
// Package systemprobeimpl implements a component to handle logging internal to the agent for system-probe.
package systemprobeimpl

import (
"context"
Expand Down
2 changes: 1 addition & 1 deletion comp/core/log/impl-systemprobe/systemprobe_logger_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-present Datadog, Inc.

package logimpl
package systemprobeimpl

import (
"testing"
Expand Down
4 changes: 2 additions & 2 deletions comp/core/log/impl-trace/trace_logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-present Datadog, Inc.

// Package logimpl provides a component that implements the log.Component for the trace-agent logger
package logimpl
// Package traceimpl provides a component that implements the log.Component for the trace-agent logger
package traceimpl

import (
"context"
Expand Down
2 changes: 1 addition & 1 deletion comp/core/log/impl-trace/trace_logger_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-present Datadog, Inc.

package logimpl
package traceimpl

import (
"testing"
Expand Down
4 changes: 2 additions & 2 deletions comp/core/tagger/impl-remote/remote.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-present Datadog, Inc.

// Package remotetaggerimpl implements a remote Tagger.
package remotetaggerimpl
// Package remoteimpl implements a remote Tagger.
package remoteimpl

import (
"context"
Expand Down
2 changes: 1 addition & 1 deletion comp/core/tagger/impl-remote/remote_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-present Datadog, Inc.

package remotetaggerimpl
package remoteimpl

import (
"context"
Expand Down
2 changes: 1 addition & 1 deletion comp/core/tagger/impl-remote/tagstore.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-present Datadog, Inc.

package remotetaggerimpl
package remoteimpl

import (
"sync"
Expand Down
2 changes: 1 addition & 1 deletion comp/core/tagger/impl-remote/tagstore_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-present Datadog, Inc.

package remotetaggerimpl
package remoteimpl

import (
"testing"
Expand Down
4 changes: 2 additions & 2 deletions comp/dogstatsd/replay/impl-noop/noop.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-2021 Datadog, Inc.

// Package replayimpl implements a no-op version of the component
package replayimpl
// Package noopimpl implements a no-op version of the component
package noopimpl

import (
"sync"
Expand Down
6 changes: 0 additions & 6 deletions comp/dogstatsd/server/server_util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,12 @@
package server

import (
"runtime"
"testing"

"github.com/stretchr/testify/assert"

"github.com/DataDog/datadog-agent/pkg/metrics/event"
"github.com/DataDog/datadog-agent/pkg/metrics/servicecheck"
"github.com/DataDog/datadog-agent/pkg/util/testutil/flake"

"go.uber.org/fx"

Expand Down Expand Up @@ -77,10 +75,6 @@ func fulfillDeps(t testing.TB) serverDeps {
}

func fulfillDepsWithConfigOverride(t testing.TB, overrides map[string]interface{}) serverDeps {
// TODO: https://datadoghq.atlassian.net/browse/AMLII-1948
if runtime.GOOS == "darwin" {
flake.Mark(t)
}
return fxutil.Test[serverDeps](t, fx.Options(
core.MockBundle(),
serverdebugimpl.MockModule(),
Expand Down
Loading
Loading