Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contrast issues of property/type status #763

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hexylena
Copy link
Contributor

@hexylena hexylena commented May 10, 2023

I'm working on updating my schemas and I am really struggling to see red from black, given the colours. Additionally if y'all care about WCAG this is a failure of SC 1.4.1, as only colour is used to convey this category information. Another method (icon, text, text decoration) needs to be used in addition to colour to pass SC1.4.1

Thus a PR to address this.

  • Replaced CD explanation with a proper HTML abbr element explaining the CD abbreviation.
  • Fixes contrast issue by including a text representation of the status (again with abbr) below each property key.

example showing new abbreviation below each property name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant