Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance regression in 2.5.x #112

Closed
kokanin opened this issue Aug 8, 2024 · 8 comments
Closed

performance regression in 2.5.x #112

kokanin opened this issue Aug 8, 2024 · 8 comments

Comments

@kokanin
Copy link

kokanin commented Aug 8, 2024

2.4.1 pulls 150 objects/second, 2.5.x pulls around 1.5, causing my patience to expire before collection finishes

@StephenHinck
Copy link

@kokanin - we pulled SharpHound v2.5.4 from BloodHound v5.13.0 for these concerns. We're working on a fix and expect to have a new v2.5.X version available here shortly!

@rvazarkar
Copy link
Contributor

https://github.com/BloodHoundAD/SharpHound/releases/tag/v2.5.6

We published v2.5.6, give it a try and see if it works for you

@kokanin
Copy link
Author

kokanin commented Sep 6, 2024

2.5.6 hovers around 2.5-2.7 objects/second

@rvazarkar
Copy link
Contributor

What collection methods are you using? We've tested this in several different environments now and have not seen performance like that anywhere

@kokanin
Copy link
Author

kokanin commented Sep 11, 2024

At least the ACL collection slows things to a crawl:
Group -> starts around 40 obj/s, ends up at 250 obj/s
Localgroup -> 30 obj/s
LocalAdmin -> 30 obj/s
Session -> 30 obj/s
ACL -> 3 obj/s

@rvazarkar
Copy link
Contributor

Would it be possible to run with -v 0 and get us the logs or is this sensitive data?

@rvazarkar
Copy link
Contributor

I believe we identified the source of this slowdown and fixed it in https://github.com/BloodHoundAD/SharpHound/releases/tag/v2.5.7

@kokanin
Copy link
Author

kokanin commented Sep 30, 2024

ACL collection going at 500 obj/s using 2.5.7 so it seems you fixed that part, thanks! It is still floating around 30 obj/s when doing -c All but I can live with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants