Skip over CAs that can't be resolved to SIDs during collection #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
ResolveHostToSid
doesn't return a valid SID when processing a CA, we don't want to collect it.Currently
ResolveHostToSid
from SHCommon falls back onto a hostname from DNS when a SID can't be determined. For now we wish to leave that behavior as is.Motivation and Context
https://specterops.atlassian.net/browse/BP-508
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: