Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Change PowerShell docs LDAPS default port from 686 to 636 to remove typo #94

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

stuartw1
Copy link
Contributor

@stuartw1 stuartw1 commented Apr 2, 2024

Description

Correct a typo in the PowerShell template. 636 is the default port used for LDAPS, not 686. This is true in IANA port assignments and the current behaviour of Sharphound collector and the targeted Windows operating systems.

Motivation and Context

Correct documentation to avoid readers becoming confused.

How Has This Been Tested?

This is a single character change to a documentation comment. Program functionality is not altered.
Use of Wireshark and reading of documentation and code confirmed that port 686 was not used but the IANA registered port for LDAPS (port 636) was.
https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search=ldap

Screenshots (if appropriate):

N/A

Types of changes

  • Chore (a change that does not modify the application functionality)
  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

I spotted a typo in a documentation comment while targeting an environment with LDAPS and thought I should submit a change. Happy to do additional work should this change require it.

Copy link

github-actions bot commented Apr 2, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@stuartw1
Copy link
Contributor Author

stuartw1 commented Apr 2, 2024

I have read the CLA Document and I hereby sign the CLA

@StephenHinck
Copy link

Thanks for catching and submitting a fix!

@StephenHinck StephenHinck merged commit c313eed into BloodHoundAD:2.X Apr 3, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants