Chore: Change PowerShell docs LDAPS default port from 686 to 636 to remove typo #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct a typo in the PowerShell template. 636 is the default port used for LDAPS, not 686. This is true in IANA port assignments and the current behaviour of Sharphound collector and the targeted Windows operating systems.
Motivation and Context
Correct documentation to avoid readers becoming confused.
How Has This Been Tested?
This is a single character change to a documentation comment. Program functionality is not altered.
Use of Wireshark and reading of documentation and code confirmed that port 686 was not used but the IANA registered port for LDAPS (port 636) was.
https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search=ldap
Screenshots (if appropriate):
N/A
Types of changes
Checklist:
I spotted a typo in a documentation comment while targeting an environment with LDAPS and thought I should submit a change. Happy to do additional work should this change require it.