Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

layoutTouchReport method is called on every changing orientation. #248

Open
canapio opened this issue Jan 12, 2016 · 1 comment · May be fixed by #249
Open

layoutTouchReport method is called on every changing orientation. #248

canapio opened this issue Jan 12, 2016 · 1 comment · May be fixed by #249
Labels
bug performance

Comments

@canapio
Copy link

canapio commented Jan 12, 2016

Hi! I'm very thank you for this powerful graph source!

But I found some wondering work.
- (void)layoutTouchReport method in BEMSimpleLineGraphView.m file is called on every changing orientation.

Following first screenshot is captured at luanching app.
Following second screenshot is captured after changing device orietation 6 times.
2016-01-12 8 24 13
2016-01-12 8 24 41

I think - (void)layoutTouchReport must be called at only one time. And if -(void)layoutSubviews method will be called, resize all view when created in - (void)layoutTouchReport.

I'm sorry for low level english.
But I'm thanks again about sexy labrary!
canapio added a commit to canapio/BEMSimpleLineGraph that referenced this issue Jan 13, 2016
@canapio
Fixes Boris-Em#248 issue that create touch event view on every changi…
1ce4053 
…ng orientation.
@canapio canapio linked a pull request Jan 13, 2016 that will close this issue
Open
@Sam-Spencer
Copy link
Collaborator

I'm not quite able to replicate this behavior using the sample app. Could you provide the exact steps taken to produce this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes issue that create touch event view on every changing orientation. canapio/BEMSimpleLineGraph
3 participants
@Sam-Spencer @canapio and others